Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u65vd-00B6oc-UM for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Apr 2025 11:00:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u65va-00CGJO-JV for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Apr 2025 11:00:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u65va-00CGEH-58 for pgsql-hackers@lists.postgresql.org; Sat, 19 Apr 2025 11:00:07 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u65vY-000r3w-1V for pgsql-hackers@lists.postgresql.org; Sat, 19 Apr 2025 11:00:06 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so26984575e9.1 for ; Sat, 19 Apr 2025 04:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745060402; x=1745665202; darn=lists.postgresql.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=+kW8krrOYdvSU/Dti4CqZ2riJjeeUNKv2M9h5/sDscU=; b=da/oRErgiqFP7M3pKaANkftIVorY9iRwGhVIhHGFQRNNV8j3CqZjzhSkCEMcEv84hs AiLY4W5nFdE8AckizXm7pI3juttSPBdESlJpFoKFIpbol9mFtaYxsjJNs9k+231dLlXh DxvI+gqn7kdwaC2nCOTcl6g9hlCAGmXwsaxEvLoKQQ2KVCwD+xNryDl0Abw1FmNctiiD rwdiTrdFykLfEef+fWspxxjbxwG/pl/657oH1CPygaI1+G759tzEWKUQfzru+H510lqU GLl4cM9zKGWoggZpOIVZC9srD0BIp6ay9+TCt3OqTUmLGGA1yXR7YVUpAmOH4d6E7y0P BPrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745060402; x=1745665202; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+kW8krrOYdvSU/Dti4CqZ2riJjeeUNKv2M9h5/sDscU=; b=sl4iKH0V56lTtnuagfS5DZ0PRLuXFy5bW/1xeJRSjX+RdONDHMToL7I4P7/dkJUZPs LtQJoPzCJDz2tJQhKO0RmfehFruAwRLLUgH+xwDYlRdspWIrJGgNYUqAQFidT30E7yx4 i8Azw/zAOwNznFcK0PNNE7Zm9ZTy/DQi1JLi328Fg7RGpi6iwc8XSAXqMu4IWHYZs6qe 5sBgcTaewVnbcD5XpudoPyPzu6tBH0NHVVrA3w+k3jEWoDgh1MPnT5mAUbhLOTrwGjPT rpD+z4c9q8Dd+EncZi6Seugnq8tlze5Rmif3/gCJGGtpiilz3+6w255DUyLRjGaYpx7Z 0Owg== X-Gm-Message-State: AOJu0Yx4RMKSLv0/2x8gWoPBtM7Xhjcc1MM5iahGOAKvEcSDppX7iBoc xW9Bf0ebziCgyqmZORkvR7ZKKvddlSP082NYtiRta9cHqn+Z9uVU X-Gm-Gg: ASbGncsu635DFwq+td8qle8qsPipw13SPhzEO45gF1bO9QjCusz4KfbiRR5SvlTyOPw a0v5NT53W5s3aQ5exc6IF3J4DjwjL8wSPOjdePl14xRz1uxMWRDBQupFzr9z6cd049kHM+0stpK BxwixPehJsc5uAfoURQfXL314o6jtQ6TT9DITOJRXYF87hVRPKaUovkmmIeFal0reOeZ0WC2Kwx EyYZrYGsjWT782NZ5FsXtmBUFDtaKigKWOOGqJIOYmLSfLFvmUmy2Is3YcD074fojVVwbH71W0U mR/ADC7ShE/0CAJpKiuq6P3DMAI4I83jCErMRf6/2wp/5BN3HjwjxQ== X-Google-Smtp-Source: AGHT+IEAkRA/ZsA/oLA+yCq/O8s/bWyPhDMEbyOMZCi+PPc013+TVQ4Mzrb7z46UPBMmBDbo1TRvsw== X-Received: by 2002:a05:600c:b8b:b0:440:66a4:8d1a with SMTP id 5b1f17b1804b1-4406ab671d0mr47449235e9.7.1745060402072; Sat, 19 Apr 2025 04:00:02 -0700 (PDT) Received: from [192.168.0.50] ([89.149.68.176]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4cd0sm5590367f8f.90.2025.04.19.04.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Apr 2025 04:00:01 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------QGpWbnSbtIImofnM7t6UeGxF" Message-ID: Date: Sat, 19 Apr 2025 14:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Typos in the code and README To: Michael Paquier Cc: PostgreSQL Developers , Daniel Gustafsson , Heikki Linnakangas , David Rowley References: <5812a0b9-b0cf-4151-9a14-d9f00e4f2858@gmail.com> <9a7763ab-5252-429d-a943-b28941e0e28b@gmail.com> Content-Language: en-US From: Alexander Lakhin In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------QGpWbnSbtIImofnM7t6UeGxF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Michael, 19.04.2025 13:04, Michael Paquier wrote: > Good finds, Alexander, particularly for the set of function and > variable names used in the comments that do not match with the > reality. I've checked all these, and they're good for me. Thank you for your attention to this! >> GIN_TUPLE_ -> GIN_TUPLE_H > This one is interested. It should be harmless in practice, but it > could cause conflicts in theory. > -- I've included it in the collection because of: #ifndef GIN_TUPLE_ ... #endif                                                   /* GIN_TUPLE_H */ Best regards, Alexander Lakhin Neon (https://neon.tech) --------------QGpWbnSbtIImofnM7t6UeGxF Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Hello Michael,

19.04.2025 13:04, Michael Paquier wrote:
Good finds, Alexander, particularly for the set of function and
variable names used in the comments that do not match with the
reality.  I've checked all these, and they're good for me.

Thank you for your attention to this!

GIN_TUPLE_ -> GIN_TUPLE_H
This one is interested.  It should be harmless in practice, but it
could cause conflicts in theory.
--

I've included it in the collection because of:
#ifndef GIN_TUPLE_
...
#endif                                                   /* GIN_TUPLE_H */

Best regards,
Alexander Lakhin
Neon (https://neon.tech)
--------------QGpWbnSbtIImofnM7t6UeGxF--