Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
To: Magnus Hagander <magnus@hagander.net>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Bruce Momjian <bruce@momjian.us>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
 Hannu Krosing <hannuk@google.com>, Robert Haas <robertmhaas@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 torikoshia <torikoshia@oss.nttdata.com>, Atsushi Torikoshi
 <atorik@gmail.com>, Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Evgeny Efimkin <efimkin@yandex-team.ru>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20210413021246.GD4231@momjian.us>
 <20210413173016.GA29955@alvherre.pgsql> <20210414183326.GA10946@momjian.us>
 <20210420162244.GD30205@momjian.us>
 <a878d5ea-64a7-485e-5d2f-177618ebc52d@oss.nttdata.com>
 <20210422092317.xnuvva2322dflxdm@nol>
 <98e3f922-629f-fe53-6027-3c668a9a0f70@oss.nttdata.com>
 <CABUevExg7inWmE8W8W=xsxFgFxn0WZXb8xLi7juMbUNDgbE81g@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <e5512912-eac9-b163-df2b-e2601ce06d27@oss.nttdata.com>
Date: Fri, 23 Apr 2021 19:04:48 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: 
 <CABUevExg7inWmE8W8W=xsxFgFxn0WZXb8xLi7juMbUNDgbE81g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e5512912-eac9-b163-df2b-e2601ce06d27%40oss.nttdata.com>
Precedence: bulk


On 2021/04/23 18:46, Magnus Hagander wrote:
> On Fri, Apr 23, 2021 at 9:10 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>>
>>
>> On 2021/04/22 18:23, Julien Rouhaud wrote:
>>> On Thu, Apr 22, 2021 at 12:28:11AM +0900, Fujii Masao wrote:
>>>>
>>>> I found another small issue in pg_stat_statements docs. The following
>>>> description in the docs should be updated so that toplevel is included?
>>>>
>>>>> This view contains one row for each distinct database ID, user ID and query ID
>>>
>>> Indeed!  I'm adding Magnus in Cc.
>>>
>>> PFA a patch to fix at, and also mention that toplevel will only
>>> contain True values if pg_stat_statements.track is set to top.
>>
>> Thanks for the patch! LGTM.
> 
> Agreed, in general. But going by the example a few lines down, I
> changed the second part to:
>          True if the query was executed as a top level statement
> +       (if <varname>pg_stat_statements.track</varname> is set to
> +       <literal>all</literal>, otherwise always false)

Isn't this confusing? Users may mistakenly read this as that the toplevel
column always indicates false if pg_stat_statements.track is not "all".


> (changes the wording, but also the name of the parameter is
> pg_stat_statements.track, not pg_stat_statements.toplevel (that's the
> column, not the parameter). Same error in the commit msg except there
> you called it pg_stat_statements.top - but that one needed some more
> fix as well)
> 
> With those changes, applied. Thanks!

Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION