Message-ID: <e56be7d9-14b1-664d-0bfc-00ce9772721c@gmail.com>
Date: Sat, 1 Jun 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: ResourceOwner refactoring
Content-Language: en-US
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Julien Rouhaud <rjuju123@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>
References: 
 <CAOBaU_Z-NaqzAv=9YntFjbJhgWkJDAwCVyzvKUQTJ2UKgK4AOw@mail.gmail.com>
 <2e10b71b-352e-b97b-1e47-658e2669cecb@iki.fi>
 <20221101001523.lsgmohl6fjwppbgx@awork3.anarazel.de>
 <9a3245db-ca03-4a47-5706-73404cfe5108@iki.fi>
 <20221101154251.64vyq7wy6w7aykrn@awork3.anarazel.de>
 <bf88d2a9-a7bc-3d68-57e3-abfba87832e9@iki.fi>
 <CAJ7c6TNijrJ+0hnTiAPDBn-tCiJsk-yvpF3Y8rXG4gTw09JYbg@mail.gmail.com>
 <d17d4d6b-c39c-7e40-9f3d-b09f19e5ccec@iki.fi>
 <CAJ7c6TM_9XtQX6xAGkH2u2-b20z-1rii9szMdW-aMHJZC_NOsA@mail.gmail.com>
 <527af829-4a03-03b0-121c-46ff79c61887@iki.fi>
 <20230710191446.pn5ltm73t2i3xtxz@awork3.anarazel.de>
 <20607b96-b275-4a57-8509-29a3ed320d3f@iki.fi>
 <48b16f57-4204-4bd2-ab42-fb24144649c4@eisentraut.org>
 <bf814230-4172-47ce-a47c-6212ee6d298e@iki.fi>
 <9cb1277d-aee4-6511-44ee-7924676f7756@gmail.com>
 <599c6674-d40b-4b31-9251-c5c073ff9fdc@iki.fi>
 <dc574fea-c83e-a600-08cd-10881762e4fa@gmail.com>
 <cd41ee65-ff35-49ef-a7bd-f8f15947df97@iki.fi>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <cd41ee65-ff35-49ef-a7bd-f8f15947df97@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/e56be7d9-14b1-664d-0bfc-00ce9772721c%40gmail.com>
Precedence: bulk

Hello Heikki,

I've stumbled upon yet another anomaly introduced with b8bff07da.

Please try the following script:
SELECT 'init' FROM pg_create_logical_replication_slot('slot',
   'test_decoding');
CREATE TABLE tbl(t text);
BEGIN;
TRUNCATE table tbl;

SELECT data FROM pg_logical_slot_get_changes('slot', NULL, NULL,
  'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');

On b8bff07da (and the current HEAD), it ends up with:
ERROR:  ResourceOwnerEnlarge called after release started

But on the previous commit, I get no error:
  data
------
(0 rows)

Best regards,
Alexander