From: "Potapov Alexander" <a.potapov@postgrespro.com>
Content-Type: multipart/mixed;
 boundary="----=_=-_OpenGroupware_org_NGMime-940475-1764493904.981471-1------"
Date: Sun, 30 Nov 2025 12:11:44 +0300
To: pgsql-hackers@lists.postgresql.org
MIME-Version: 1.0
Message-ID: <e59bb-692c0a80-5-6f987180@170377126>
Subject: PG version is not seen in =?utf-8?q?pg=5Fupgrade?= test log
Archived-At: 
 <https://www.postgresql.org/message-id/e59bb-692c0a80-5-6f987180%40170377126>
Precedence: bulk

------=_=-_OpenGroupware_org_NGMime-940475-1764493904.981471-1------
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Length: 1463

Hello!

I ran pg=5Fupgrade tests (make check -C src/bin/pg=5Fupgrade) and found=
 that test log does not contain PG version:
   (file: src/bin/pg=5Fupgrade/tmp=5Fcheck/log/regress=5Flog=5F002=5Fpg=
=5Fupgrade)
   Name: old=5Fnode
   Data directory: /home/dev/code/postgrespro3/src/bin/pg=5Fupgrade/tmp=
=5Fcheck/t=5F002=5Fpg=5Fupgrade=5Fold=5Fnode=5Fdata/pgdata
   Backup directory: /home/dev/code/postgrespro3/src/bin/pg=5Fupgrade/t=
mp=5Fcheck/t=5F002=5Fpg=5Fupgrade=5Fold=5Fnode=5Fdata/backup
This happens because $node->=5Fset=5Fpg=5Fversion is called after invoc=
ation of $node->dump=5Finfo. To fix it we should change line order in C=
luster.pm file. The result looks like:
   Name: old=5Fnode
   Version: 19devel
   Data directory: /home/dev/code/postgrespro3/src/bin/pg=5Fupgrade/tmp=
=5Fcheck/t=5F002=5Fpg=5Fupgrade=5Fold=5Fnode=5Fdata/pgdata
   Backup directory: /home/dev/code/postgrespro3/src/bin/pg=5Fupgrade/t=
mp=5Fcheck/t=5F002=5Fpg=5Fupgrade=5Fold=5Fnode=5Fdata/backup
=20
The change I suggest is:
   --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
   +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
   @@ -1647,10 +1647,10 @@ sub new
           or
           BAIL=5FOUT("could not create data directory \"$node->{=5Fbas=
edir}\": $!");
   -    $node->dump=5Finfo;
   -
       $node->=5Fset=5Fpg=5Fversion;
   +    $node->dump=5Finfo;
   +
       my $ver =3D $node->{=5Fpg=5Fversion};
=20
Patch attached.


Best regards,
Alexander Potapov

------=_=-_OpenGroupware_org_NGMime-940475-1764493904.981471-1------
Content-Type: application/octet-stream
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-Show-PG-version-in-pg_upgrade-test-log.patch"
Content-Length: 1155

RnJvbSAxNTZlOWE5MzM3MzBkMGI2YTM1MjczZTE0YjA5NGE5NmExZWEzMzhlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQb3RhcG92IEFsZXhhbmRlciA8YS5wb3RhcG92QHBv
c3RncmVzcHJvLnJ1PgpEYXRlOiBUaHUsIDIzIE9jdCAyMDI1IDEwOjA5OjI0ICswMzAwClN1
YmplY3Q6IFtQQVRDSF0gU2hvdyBQRyB2ZXJzaW9uIGluIHBnX3VwZ3JhZGUgdGVzdCBsb2cK
Ci0tLQogc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvQ2x1c3Rlci5wbSB8IDQgKyst
LQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9zcmMvdGVzdC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9DbHVzdGVyLnBtIGIv
c3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvQ2x1c3Rlci5wbQppbmRleCAzNTQxM2Yx
NDAxOS4uNzQ3NTI4YzRhZjEgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNR
TC9UZXN0L0NsdXN0ZXIucG0KKysrIGIvc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3Qv
Q2x1c3Rlci5wbQpAQCAtMTY0NywxMCArMTY0NywxMCBAQCBzdWIgbmV3CiAJICBvcgogCSAg
QkFJTF9PVVQoImNvdWxkIG5vdCBjcmVhdGUgZGF0YSBkaXJlY3RvcnkgXCIkbm9kZS0+e19i
YXNlZGlyfVwiOiAkISIpOwogCi0JJG5vZGUtPmR1bXBfaW5mbzsKLQogCSRub2RlLT5fc2V0
X3BnX3ZlcnNpb247CiAKKwkkbm9kZS0+ZHVtcF9pbmZvOworCiAJbXkgJHZlciA9ICRub2Rl
LT57X3BnX3ZlcnNpb259OwogCiAJIyBVc2UgYSBzdWJjbGFzcyBhcyBkZWZpbmVkIGJlbG93
IChvciBlbHNld2hlcmUpIGlmIHRoaXMgdmVyc2lvbgotLSAKMi40MC4xCgo=

------=_=-_OpenGroupware_org_NGMime-940475-1764493904.981471-1--------