Content-Type: multipart/alternative;
 boundary="------------TCS0K0XeOfX1i82dazzJBeOf"
Message-ID: <e5a8c1df-04e5-4343-85ef-5df2a7e3d90c@gmail.com>
Date: Fri, 16 Jan 2026 22:00:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Noah Misch <noah@leadboat.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <202512111958.6ymanstmexrk@alvherre.pgsql>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <202512111958.6ymanstmexrk@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/e5a8c1df-04e5-4343-85ef-5df2a7e3d90c%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------TCS0K0XeOfX1i82dazzJBeOf
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Alvaro and Mihail,

11.12.2025 22:04, Álvaro Herrera wrote:
> On 2025-Dec-09, Mihail Nikalayeu wrote:
>
>> After some investigation I ended up with a much simpler fix.
>> It is self-explanatory in code and a commit message.
> Yeah, that makes sense.  It's what I was trying to say in
> https://postgr.es/m/202512072050.hcyysny65ugj@alvherre.pgsql
> Pushed your patch, thanks.

Thank you for fixing that once again! But it looks like the
"invalid arbiter index list" error is still not completely gone. It was
produced recently by new 010_index_concurrently_upsert test [1]:
364/364 postgresql:test_misc / test_misc/010_index_concurrently_upsert ERROR            22.47s   exit status 29

010_index_concurrently_upsert_node.log contains:
2026-01-08 12:59:26.336 CET [1265129][client backend][74/5:0] ERROR:  invalid arbiter index list
2026-01-08 12:59:26.336 CET [1265129][client backend][74/5:0] STATEMENT:  INSERT INTO test.tblparted VALUES (13, now()) 
ON CONFLICT (i) DO UPDATE SET updated_at = now();

I'm able to reproduce it locally when running 10+ instances of the test
in parallel on a pretty slow machine:
...
1       [18:46:52]
1       All tests successful.
1       Files=1, Tests=68, 36 wallclock secs ( 0.53 usr  0.03 sys + 4.06 cusr  3.38 csys =  8.00 CPU)
1       Result: PASS
3       [18:49:23] t/010_index_concurrently_upsert.pl ..
3       Dubious, test returned 29 (wstat 7424, 0x1d00)
3       Failed 1/45 subtests
3       [18:49:23]
3
3       Test Summary Report
3       -------------------
3       t/010_index_concurrently_upsert.pl (Wstat: 7424 (exited 29) Tests: 45 Failed: 1)
3         Failed test:  45
3         Non-zero exit status: 29
3         Parse errors: No plan found in TAP output
3       Files=1, Tests=45, 186 wallclock secs ( 0.40 usr  0.03 sys + 14.82 cusr 16.18 csys = 31.43 CPU)
3       Result: FAIL

With the more verbose error message, I can see:
src/test/modules/test_misc_3/tmp_check/log/010_index_concurrently_upsert_node.log:
2026-01-16 18:46:39.367 UTC [postgres][2047103:8][client backend] [010_index_concurrently_upsert.pl][74/5:0] ERROR:  
invalid arbiter index list: list_length(rootResultRelInfo->ri_onConflictArbiterIndexes): 1, list_length(arbiterIndexes): 
2, additional_arbiters: 0
The numbers are the same from three failures in a row I observed.

(I can add more debugging and dig deeper, if needed.)

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=adder&dt=2026-01-08%2011%3A55%3A58

Best regards,
Alexander
--------------TCS0K0XeOfX1i82dazzJBeOf
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hello Alvaro and Mihail,<br>
      <br>
      11.12.2025 22:04, Álvaro Herrera wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:202512111958.6ymanstmexrk@alvherre.pgsql">
      <pre wrap="" class="moz-quote-pre">On 2025-Dec-09, Mihail Nikalayeu wrote:

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">After some investigation I ended up with a much simpler fix.
It is self-explanatory in code and a commit message.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Yeah, that makes sense.  It's what I was trying to say in
<a class="moz-txt-link-freetext" href="https://postgr.es/m/202512072050.hcyysny65ugj@alvherre.pgsql">https://postgr.es/m/202512072050.hcyysny65ugj@alvherre.pgsql</a>
Pushed your patch, thanks.
</pre>
    </blockquote>
    <br>
    Thank you for fixing that once again! But it looks like the<br>
    "invalid arbiter index list" error is still not completely gone. It
    was<br>
    produced recently by new 010_index_concurrently_upsert test [1]:<br>
    364/364 postgresql:test_misc /
    test_misc/010_index_concurrently_upsert                 
    ERROR            22.47s   exit status 29<br>
    <br>
    010_index_concurrently_upsert_node.log contains:<br>
    2026-01-08 12:59:26.336 CET [1265129][client backend][74/5:0]
    ERROR:  invalid arbiter index list<br>
    2026-01-08 12:59:26.336 CET [1265129][client backend][74/5:0]
    STATEMENT:  INSERT INTO test.tblparted VALUES (13, now()) ON
    CONFLICT (i) DO UPDATE SET updated_at = now();<br>
    <br>
    I'm able to reproduce it locally when running 10+ instances of the
    test<br>
    in parallel on a pretty slow machine:<br>
    ...<br>
    1       [18:46:52]<br>
    1       All tests successful.<br>
    1       Files=1, Tests=68, 36 wallclock secs ( 0.53 usr  0.03 sys + 
    4.06 cusr  3.38 csys =  8.00 CPU)<br>
    1       Result: PASS<br>
    3       [18:49:23] t/010_index_concurrently_upsert.pl ..<br>
    3       Dubious, test returned 29 (wstat 7424, 0x1d00)<br>
    3       Failed 1/45 subtests<br>
    3       [18:49:23]<br>
    3<br>
    3       Test Summary Report<br>
    3       -------------------<br>
    3       t/010_index_concurrently_upsert.pl (Wstat: 7424 (exited 29)
    Tests: 45 Failed: 1)<br>
    3         Failed test:  45<br>
    3         Non-zero exit status: 29<br>
    3         Parse errors: No plan found in TAP output<br>
    3       Files=1, Tests=45, 186 wallclock secs ( 0.40 usr  0.03 sys +
    14.82 cusr 16.18 csys = 31.43 CPU)<br>
    3       Result: FAIL<br>
    <br>
    With the more verbose error message, I can see:<br>
src/test/modules/test_misc_3/tmp_check/log/010_index_concurrently_upsert_node.log:<br>
    2026-01-16 18:46:39.367 UTC [postgres][2047103:8][client backend]
    [010_index_concurrently_upsert.pl][74/5:0] ERROR:  invalid arbiter
    index list:
    list_length(rootResultRelInfo-&gt;ri_onConflictArbiterIndexes): 1,
    list_length(arbiterIndexes): 2, additional_arbiters: 0<br>
    The numbers are the same from three failures in a row I observed.<br>
    <br>
    (I can add more debugging and dig deeper, if needed.)<br>
    <br>
    [1] 
<a class="moz-txt-link-freetext" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=adder&amp;dt=2026-01-08%2011%3A55%3A58">https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=adder&amp;dt=2026-01-08%2011%3A55%3A58</a><br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------TCS0K0XeOfX1i82dazzJBeOf--