Feedback-ID: i131946ab:Fastmail
Message-ID: <e5e13d55-8c8b-30a6-0b13-0304a3e562dd@enterprisedb.com>
Date: Tue, 1 Nov 2022 17:00:27 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement
 -Wshadow=compatible-local
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
 Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>,
 =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>
References: <20221101180158.l4zg6ljah5ow2vvo@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20221101180158.l4zg6ljah5ow2vvo@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e5e13d55-8c8b-30a6-0b13-0304a3e562dd%40enterprisedb.com>
Precedence: bulk

On 01.11.22 19:01, Andres Freund wrote:
> I don't know how much longer we can rely on headers being
> -Wdeclaration-after-statement clean, my impression is that people don't have a
> lot of patience for C89isms anymore.

> I wonder if we should try to use -isystem for a bunch of external
> dependencies. That way we can keep the more aggressive warnings with a lower
> likelihood of conflicting with stuff outside of our control.

Python has the same issues.  There are a few other Python-embedding 
projects that use -Wdeclaration-after-statement and complain if the 
Python headers violate it.  But it's getting tedious.  -isystem would be 
a better solution.