Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEPsm-003yfl-2R for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 11:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wEPsl-00F0iB-1E for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 11:00:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEPsl-00F0i3-0H for pgsql-hackers@lists.postgresql.org; Sun, 19 Apr 2026 11:00:07 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wEPsj-00000001xlz-03tp for pgsql-hackers@lists.postgresql.org; Sun, 19 Apr 2026 11:00:06 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-38ccde812ecso20365361fa.0 for ; Sun, 19 Apr 2026 04:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776596403; x=1777201203; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YBHJIbx8+9O2KI9tOHdGAZeSl8SEPaCQH8wDISeayxI=; b=NmAx6QmDnar88IqZ7yShfYU0F1atB/MvjVx9Kw5IXsXC6oezcK9R1BOrh6FtDaWeUC aMrWfpwv+XWgJmHVtTT3KffcgNbzKJbjaNP5C9TnDXfsR+aeEsWKgY9oak4DQr4ugqoh jE22Zj/CRYvOOrzLMb9p8TPba+l5dTcGdM6n984/7bKbbWhpWWoo/4jpPDOTA0Ep5Pje ntlPemVVwd1FXCWe6wa6oo6Hsgl0BFpbvi8d36HPPJvn4COnSs4v7akQF89vzOsoto+V /oP1F/XIbBr6RvofT+zcJUUz+R89bnABojutgGH6OuPb8BSLPec3PYDPfE1h9ai/6RLD rIMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776596403; x=1777201203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YBHJIbx8+9O2KI9tOHdGAZeSl8SEPaCQH8wDISeayxI=; b=fMa6Z1NJJZGxAQrvhSCWaBZAqBxbtHWKbw1X9vwLOcON49t74KcaRs61TsaotvIMzQ 8MvV0AjcxDeAL9C8hGxauGEGAOShiY9QhoFQ711WqNtyzUAdFkHzupj6XfdqRqZ/ShLj bmpCaQVD21rBqVRJxQYVaUOLni4QNU+/lYXUQq/2YxdhaoM40KJPkq9dE/jshpehosJo qShAhkS8So7+H/JsW+TfI4smNmD3x67yvVfsug4XryyoEJg+61TBQkpsELl38BUjFeyR 1om7M9kETfv1H+zdBWDx0TFFOMmShjM6RRpgaWFBtM8nc31oYKRl+XYLKnLJF+K5bxU9 HaaA== X-Forwarded-Encrypted: i=1; AFNElJ9HdRvcLXvJcBdvNDX16/QSoFz5DhEhwryT+EWasUNndFqgNdC1KGJPtJJItsRj69ueVcmWEwTU5R2fRMIr@lists.postgresql.org X-Gm-Message-State: AOJu0YyftxtrdcU3Ph3yn1mUsfDLVik8VobUHq6mmJ90BgBaOkwU+8jZ iHtPrJsBNcufcoHTWgwazWRrvvOjBwwWSTlC1NYNtbC2dlFKfTJHZK7z X-Gm-Gg: AeBDieu42cMfCzvIR7j+zIXFARLpaH7yLG1YTD39MZW9x50P1Prhe/l9g+HE0sKp9o9 51KCGGpaByYEF/L8Txb3WzP1NHYR3njCsmGprYrXTLq+ODXOnsPWrm7vK/8wcMrtVWPtNZdrbOE J24qlh9w/NDQ3Xa1cKxgw6jhCMQgTQhl+n5T2uzm/bPkVW00kSLGsQ9mWq4gTdGrOJ3ktZDuoJy UxL2Sosn+FP8AMLYUta2RPr6+B5PbnHae6FzpjXeRTlGstULlVjKqrKEo3uTTHNw/RevXRjlsMC kyKf9Ayun6gG2B/s722hk0XtTzdAFzgaWbnHCPXsqtAufrVZw98SMBBQ7uyHHjVm/j07mCu4n+m QfXXsuXLsjPQJ45jgw2sGfu9Fclo6G8mVI3C3WmiVvGCKdoc3U68GadKq/8PcUx/gRg8JPg32tn v5QW3SSPR8BxWxfO6lgWjxfRlJ1ef8KbLA34k= X-Received: by 2002:a2e:2e15:0:b0:387:5ea:e298 with SMTP id 38308e7fff4ca-38ec8ff188bmr19482231fa.8.1776596403147; Sun, 19 Apr 2026 04:00:03 -0700 (PDT) Received: from [192.168.0.50] ([89.149.68.143]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb75b033sm18055671fa.39.2026.04.19.04.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2026 04:00:02 -0700 (PDT) Message-ID: Date: Sun, 19 Apr 2026 14:00:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Adding REPACK [concurrently] To: Antonin Houska , Alvaro Herrera Cc: Andres Freund , Mihail Nikalayeu , Amit Kapila , Srinath Reddy Sadipiralla , Matthias van de Meent , Pg Hackers , Robert Treat References: <9539.1775724194@localhost> <112208.1776173876@localhost> <25514.1776264611@localhost> <38385.1776277704@localhost> <44458.1776540188@localhost> Content-Language: en-US From: Alexander Lakhin In-Reply-To: <44458.1776540188@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Antonin and Alvaro, I've noticed a wrong reference coined in commit 28d534e2a: A comment in repack_worker.c says:     /*      * Override the default bgworker_die() with die() so we can use      * CHECK_FOR_INTERRUPTS().      */     pqsignal(SIGTERM, die);     BackgroundWorkerUnblockSignals(); but bgworker_die() doesn't exist since d62dca3b2 (2026-02-18). Maybe this is not needed anymore? Best regards, Alexander