Message-ID: <e618cae7-b421-2e1f-d777-38946a669879@postgrespro.ru>
Date: Tue, 11 Oct 2022 11:06:57 +0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: Fast COPY FROM based on batch insert
Content-Language: en-US
To: Etsuro Fujita <etsuro.fujita@gmail.com>, Zhihong Yu <zyu@yugabyte.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Amit Langote <amitlangote09@gmail.com>, tanghy.fnst@fujitsu.com,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>, houzj.fnst@fujitsu.com
References: 
 <TYAPR01MB2990B8451B4C725242E270F7FE979@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <CAPmGK15Z1kvZE0oULa+JD_CKzc4NwWEZYAfJ26VkoVYg1md63g@mail.gmail.com>
 <45ad1b94-339b-a841-8885-67ebe6fc5bc1@postgrespro.ru>
 <CAPmGK14ov-MbQtwHuSK5ESUeL1csgCVC1MAAwZxgV=NWsBE2ZQ@mail.gmail.com>
 <57733596-5fd6-07ec-d65c-67411411f10e@postgrespro.ru>
 <CAPmGK145252jR4fygMTtJcUA4fCoKPkbykir9p9XupT6N903fQ@mail.gmail.com>
 <05bc8819-3e53-d884-a0d0-a17ffa5febef@postgrespro.ru>
 <CAPmGK15jd6gEt_XyswQ4uEG6XVdz9DNC5uqW1KK=1A_ehLTEYw@mail.gmail.com>
 <09ff35ff-291f-d9e9-a0ed-55e6bb9732fc@postgrespro.ru>
 <CAPmGK15WWjXsyBE05vDjvi37012WTiW-j=-Y8Uo=VqPRpsbOgg@mail.gmail.com>
 <CAPmGK15ZqOfE4N0PknZMzW96DRdZOA8ih_7591JMqAZu-Nhiiw@mail.gmail.com>
 <CALNJ-vQd-bMrydDzUg5+fr9w+gTnErCADhk3KSi72_RCcKJw=Q@mail.gmail.com>
 <CAPmGK17pyQgsz9zy9T4avRNw8TY74T5-v1n0vSUgSn8tmjGgVg@mail.gmail.com>
 <CAPmGK1476Smi59cszMZM7z7oeFJ5NF9MOChmHjsF2OZ48eyg-w@mail.gmail.com>
 <CAPmGK160mQENUMOjMa03-QRR77wiZrA375tiT6KY_wP-hsNu2Q@mail.gmail.com>
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: 
 <CAPmGK160mQENUMOjMa03-QRR77wiZrA375tiT6KY_wP-hsNu2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e618cae7-b421-2e1f-d777-38946a669879%40postgrespro.ru>
Precedence: bulk

On 10/7/22 11:18, Etsuro Fujita wrote:
> On Tue, Sep 27, 2022 at 6:03 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> I will review the patch a bit more, but I feel that it is
>> in good shape.
> 
> One thing I noticed is this bit added to CopyMultiInsertBufferFlush()
> to run triggers on the foreign table.
> 
> +           /* Run AFTER ROW INSERT triggers */
> +           if (resultRelInfo->ri_TrigDesc != NULL &&
> +               (resultRelInfo->ri_TrigDesc->trig_insert_after_row ||
> +                resultRelInfo->ri_TrigDesc->trig_insert_new_table))
> +           {
> +               Oid         relid =
> RelationGetRelid(resultRelInfo->ri_RelationDesc);
> +
> +               for (i = 0; i < inserted; i++)
> +               {
> +                   TupleTableSlot *slot = rslots[i];
> +
> +                   /*
> +                    * AFTER ROW Triggers might reference the tableoid column,
> +                    * so (re-)initialize tts_tableOid before evaluating them.
> +                    */
> +                   slot->tts_tableOid = relid;
> +
> +                   ExecARInsertTriggers(estate, resultRelInfo,
> +                                        slot, NIL,
> +                                        cstate->transition_capture);
> +               }
> +           }
> 
> Since foreign tables cannot have transition tables, we have
> trig_insert_new_table=false.  So I simplified the if test and added an
> assertion ensuring trig_insert_new_table=false.  Attached is a new
> version of the patch.  I tweaked some comments a bit as well.  I think
> the patch is committable.  So I plan on committing it next week if
> there are no objections.
I reviewed the patch one more time. Only one question: bistate and 
ri_FdwRoutine are strongly bounded. Maybe to add some assertion on 
(ri_FdwRoutine XOR bistate) ? Just to prevent possible errors in future.

-- 
Regards
Andrey Lepikhov
Postgres Professional