Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tq6G6-00Gzut-QQ for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Mar 2025 08:07:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tq6G5-002XHZ-Ft for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Mar 2025 08:07:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tq6G5-002XGT-1a for pgsql-hackers@lists.postgresql.org; Thu, 06 Mar 2025 08:07:09 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tq6G2-001GDW-2v for pgsql-hackers@lists.postgresql.org; Thu, 06 Mar 2025 08:07:08 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-22398e09e39so4977575ad.3 for ; Thu, 06 Mar 2025 00:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1741248426; x=1741853226; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kJ/TWffJgYVczv3Ue9sGEVh5Dwn7bdXjNY5OQ6FifE4=; b=wMOS/71GJY4R4eJFcRXpHdQ3PvINS/pGqfGYzE7Zswnj3CDYD8nPERdMWN4zFFrhwD BdlTdk8MHdzqglSmIkw0xg2dAuLJe1Q3xYxZZAWvnMqUv6iCSrzOepc/Dp65oqpq+2k+ cMXylbikvkzlWiB3R39IQRGIuJfa96ccT12glKAI0V5gDsWnWnc2yiobwDuamMxEzJxH 3+RK0KElWjz7rOmYUVHrAvuiKbNLokxhF2LeJ9SVi/CLaVc4g9DdtLpNknD/AcFPe7z/ vwWavRD7mppkr1A5udk4Ye2F3zdyazmYjahTMYdTbhE/5ye3elDXF4ndh4PsSBTIh7/T FSfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741248426; x=1741853226; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kJ/TWffJgYVczv3Ue9sGEVh5Dwn7bdXjNY5OQ6FifE4=; b=haXezyZl8tLUiYvDl53tDAD6BSvcOtHQS6x3Xrbli6Qpc9S/tiFIzWsBYIORt5hqcM p1qsxSb0I546DbVqWNJ8hix1ANkOO108jtl5cK/5dgXZGi9lrbNjjYpnAkBGgWVzG/kn jycYi4QDSM12N+iffHOJjMpOKO8XrvZNLL/xDeLf1vgbXNh5SfUEpULoLDF/CzInkBIh hjKAs+O7xQz6S/F6y+IZMfI9RSP3ENEV3yHx6WNen2QUf+WcPaGgwhWxHBioDNbUvsRH 9pog9xHFFihPlyevOvC5E0t2rxzw7bz/suMPHfYtrs/5aTI3i0EX+ZWGHEsvyStldiyn BsIw== X-Forwarded-Encrypted: i=1; AJvYcCVh8t+BUSJikakbf2O4UljHYAxksuMe333QDkZl+HYL26n8Pts2dym1NKHszNMHKkwD0zJFDzhS0ihsnOfy@lists.postgresql.org X-Gm-Message-State: AOJu0Yw7RaUZKRv2Wy9OCKkaLL5Z1Yvs1R56RKxPbdYubdlF/Y4ZYEgd HyPeW80hX2pn4ZB8RoooNKod1Uh/9UO3mlKlundbY5Hweaou2uHxwi+EVyQuPA== X-Gm-Gg: ASbGncuE/ZpXbfosA/wTI263hyxjlsJPesujc6ojlqvIM5TEOL1/vyzDDJTEr9JWA6m Eb7v1ReiYV9z3Yyg9DW9+fY+OUsjw4tQP6lzfWvcZKSFBWmNKVmns07DT4UssAF6GHo/URwYdDT xB1insoNqxkPfFT1KKhG3sVbmRZ908ZWgxiQTrmBgQm5j88WqPVqqFA8zNFhGNYmdKnaMwZcOSD 9K1yHgYoCYJr/PgWI8HnByD2XIM2EDuSRlv7RVRX+TAA3/Bz+fkU7+YlT/cDFCwJJ6t18TEDCgc qZrEgKIpUcvTkbPqVgwiFGEj/MBFIRSfapFCZ4/gpX96xlnK7Ubugcmik5dYuvhoUOGoeRYtC70 Y3LCt5xzgo9k= X-Google-Smtp-Source: AGHT+IFcEJUpDbu3eqi3NI+3dXz1yrdsDu/FYrbGsrbBHoQUYAekyY+grQY5IXCaB8W2qJckxpGlcw== X-Received: by 2002:a17:903:2990:b0:21f:988d:5758 with SMTP id d9443c01a7336-223f1d10659mr120174915ad.35.1741248426121; Thu, 06 Mar 2025 00:07:06 -0800 (PST) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7369824554bsm740357b3a.69.2025.03.06.00.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 00:07:05 -0800 (PST) Message-ID: Subject: Re: Statistics Import and Export From: Jeff Davis To: Corey Huinker , Andres Freund Cc: Nathan Bossart , Tom Lane , Michael Paquier , jian he , Bruce Momjian , Matthias van de Meent , Magnus Hagander , Stephen Frost , Ashutosh Bapat , Peter Smith , PostgreSQL Hackers , alvherre@alvh.no-ip.org Date: Thu, 06 Mar 2025 00:07:01 -0800 In-Reply-To: References: <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com> <6rpmhyrtci4epuzay7y5xvd2cwdwb6zmtt6ofxrvakyawxhm7s@6grajbpr4kij> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2025-03-05 at 23:04 -0500, Corey Huinker wrote: >=20 > Anyway, here's a rebased set of the existing up-for-consideration > patches, plus the optimization of avoiding querying on non-expression > indexes. Patch 0001 contains a bug: it returns REQ_STATS early, before doing any exclusions. But I agree the previous code was hard to read in one place, and redundant in another, so I will commit a fixup. Regards, Jeff Davis