Feedback-ID: i131946ab:Fastmail
Message-ID: <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
Date: Wed, 1 Jun 2022 16:11:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: pg_upgrade test writes to source directory
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>,
 pgsql-hackers@postgresql.org
References: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
 <Yo/mWGJjCHOH3eB1@paquier.xyz> <20220526205218.GC19626@telsasoft.com>
 <Yo/5MlXbwY4UhMnm@paquier.xyz> <2464542.1653603596@sss.pgh.pa.us>
 <YpAMBqPrusng47e0@paquier.xyz> <2480063.1653609068@sss.pgh.pa.us>
 <YpAV1y8CUXGGkPJQ@paquier.xyz>
 <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
 <3131727.1653768841@sss.pgh.pa.us> <YpXA7XHZtunxalTr@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <YpXA7XHZtunxalTr@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e65a862a-24aa-7482-6d98-49fbb048f22f%40enterprisedb.com>
Precedence: bulk

On 31.05.22 09:17, Michael Paquier wrote:
> On Sat, May 28, 2022 at 04:14:01PM -0400, Tom Lane wrote:
>> Yeah, I'd noticed the obsoleted comments too, but not bothered to complain
>> since that was just WIP and not an officially proposed patch.  I'll be
>> happy to review if you want to put up a full patch.
> Well, here is a formal patch set, then.  Please feel free to comment.
> 
> FWIW, I am on the fence with dropping TESTDIR, as it could be used by
> out-of-core test code as well.  If there are doubts about
> back-patching the first part, doing that only on HEAD would be fine to
> fix the problem of this thread.

I don't understand the point of this first patch at all.  Why define 
TESTOUTDIR as a separate variable if it's always TESTDIR + tmp_check? 
Why define TESTOUTDIR in pg_regress invocations, if nothing uses it?  If 
you want it as a separate variable, it could be defined in some Per 
utility module, but I don't see why it needs to be in Makefile.global. 
What is the problem that this is trying to solve?