Feedback-ID: i131946ab:Fastmail
Message-ID: <e6c67eca-f55e-4c8f-03f4-e6104c7373f4@enterprisedb.com>
Date: Tue, 10 Jan 2023 06:07:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: split TOAST support out of postgres.h
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ddcce239-0f29-6e62-4b47-1f8ca742addf@enterprisedb.com>
 <320834.1672240076@sss.pgh.pa.us>
 <fa03b216-2e81-4fe9-c4fa-bbf3c2058d0b@enterprisedb.com>
 <749875.1672419036@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <749875.1672419036@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/e6c67eca-f55e-4c8f-03f4-e6104c7373f4%40enterprisedb.com>
Precedence: bulk

On 30.12.22 17:50, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> On 28.12.22 16:07, Tom Lane wrote:
>>> I dunno, #3 seems kind of unprincipled.  Also, since fmgr.h is included
>>> so widely, I doubt it is buying very much in terms of reducing header
>>> footprint.  How bad is it to do #2?
> 
>> See this incremental patch set.
> 
> Wow, 41 files requiring varatt.h is a lot fewer than I would have guessed.
> I think that bears out my feeling that fmgr.h wasn't a great location:
> I count 117 #includes of that, many of which are in .h files themselves
> so that many more .c files would be required to read them.

committed