Message-ID: <e71e029309171eb8b6ca393306f9bc5acfbfdf8f.camel@j-davis.com>
Subject: Re: [17] CREATE SUBSCRIPTION ... SERVER
From: Jeff Davis <pgsql@j-davis.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway
	 <mail@joeconway.com>, pgsql-hackers@postgresql.org
Date: Fri, 05 Jan 2024 00:04:26 -0800
In-Reply-To: <CAExHW5v5poohyfNRVQp3yjVE56ej0dWvVMbysSSVtg21aHT3uQ@mail.gmail.com>
References: <149ff9264db27cdf724b65709fbbaee4bf316835.camel@j-davis.com>
	 <CAExHW5vv-78ixJs3arsuZ+12A4AyqehJnDPhejp0m4FAKG6JZA@mail.gmail.com>
	 <830a2bc6cbbb2e6e01c6c0d9f31f320822e10603.camel@j-davis.com>
	 <CAExHW5sAo4Gv3AwuxQNGSQ2Z45B8_MZEb-SG-B8D-hLMdrquAg@mail.gmail.com>
	 <e531ec798298a21d671babd45849092850b8675e.camel@j-davis.com>
	 <ac4042d6-204c-9661-9949-79ab8a1f8604@joeconway.com>
	 <CAExHW5unvpDv6yMSmqurHP7Du1PqoJFWVxeK-4YNm5EnoNJiSQ@mail.gmail.com>
	 <433d0845248e86c0317d9d396926182cfe157340.camel@j-davis.com>
	 <CAExHW5sQVJeCgCGMkum_k4Z4VPaK5GkdAjHW-d+F3MngBZ9qBA@mail.gmail.com>
	 <05ae37abb207cd6bf6b126780024692d91402b0b.camel@j-davis.com>
	 <93392ffa941ab0d436e19e0ab5d04d0e42c02d3f.camel@j-davis.com>
	 <26be917cb07b6aa3ef5dd15f6b59d1b375ece6e8.camel@j-davis.com>
	 <CALj2ACXDua2Az15Kj3OZFaRm49G8-faemiEEv8t9GNCcsxv8Hw@mail.gmail.com>
	 <55201bd916e748acfc754c8f95880dae8e4e5ed0.camel@j-davis.com>
	 <CAExHW5v5poohyfNRVQp3yjVE56ej0dWvVMbysSSVtg21aHT3uQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/e71e029309171eb8b6ca393306f9bc5acfbfdf8f.camel%40j-davis.com>
Precedence: bulk

On Fri, 2024-01-05 at 12:49 +0530, Ashutosh Bapat wrote:
> Can you please provide an example using postgres_fdw to create a
> subscription using this patch. I think we should document it in
> postgres_fdw and add a test for the same.

There's a basic test for postgres_fdw in patch 0003, just testing the
syntax and validation.

A manual end-to-end test is pretty straightforward:

  -- on publisher
  create table foo(i int primary key);
  create publication pub1 for table foo;
  insert into foo values(42);

  -- on subscriber
  create extension postgres_fdw;
  create table foo(i int primary key);
  create server server1
    foreign data wrapper postgres_fdw
    options (host '/tmp', port '5432', dbname 'postgres');
  create user mapping for u1 server server1
    options (user 'u1');
  select pg_conninfo_from_server('server1','u1',true);
  create subscription sub1 server server1 publication pub1;

I don't think we need to add an end-to-end test for each FDW, because
it's just using the assembled connection string. To see if it's
assembling the connection string properly, we can unit test with
pg_conninfo_from_server().

Regards,
	Jeff Davis