Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b
MIME-Version: 1.0
Message-Id: <e7671bde-37e0-4ead-a9ef-8a63ac43fa99@app.fastmail.com>
In-Reply-To: 
 <CAA4eK1KJ2O7qaKSnOC05kRnu9KYQa-ye80TnfP1TZNqogqEuuA@mail.gmail.com>
References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com>
 <e02a2c17-22e5-4ba6-b788-de696ab74f1e@app.fastmail.com>
 <CALDaNm098Jkbh+ye6zMj9Ro9j1bBe6FfPV80BFbs1=pUuTJ07g@mail.gmail.com>
 <2736443c-58e3-42df-8cc4-8c66106e3da5@app.fastmail.com>
 <CAA4eK1KtGC-v_CYd8yaCwisrQvoZN=+As90p9hBM29DAxA+Pmg@mail.gmail.com>
 <CANhcyEUdYCR9oSt4HsZRqYZZVXsb4x-HoPGqDSxSeA2SYz-YGg@mail.gmail.com>
 <CAA4eK1KMQNMhSPmsRdrCQpuc=Tsc08h6=XkLNZ5F35Q2REom6g@mail.gmail.com>
 <CANhcyEXjOcnOJKdOfK8Z1+bbymuZzwSjrppbt4FKHbrDD_t7Mg@mail.gmail.com>
 <CANhcyEUCt-g4JLQU3Q3ofFk_Vt-Tqh3ZdXoLcpT8fjz9LY_-ww@mail.gmail.com>
 <bcd3db13-f56e-47e3-8fa7-7f0c6243c8a6@app.fastmail.com>
 <CAA4eK1JRgnhv_ySzuFjN7UaX9qxz5Hqcwew7Fk=+AbJbu0Kd9w@mail.gmail.com>
 <TY3PR01MB98895BA6C1D72CB8582CACC4F5682@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <aabc91d2-505b-4412-af08-7dae2df1d437@app.fastmail.com>
 <78c88fa4-4960-4ce9-ae45-cda6302bd824@eisentraut.org>
 <CAA4eK1+RXJmC6y2LREuswDUzuPsxmf2S+sc6_72cieG3O0Txew@mail.gmail.com>
 <d11e8cfb-b987-45d2-bf56-1e8552145b1c@eisentraut.org>
 <TY3PR01MB9889A8313E87FB76957F6BF9F5752@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <CAA4eK1KJ2O7qaKSnOC05kRnu9KYQa-ye80TnfP1TZNqogqEuuA@mail.gmail.com>
Date: Tue, 23 Jan 2024 20:44:15 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Amit Kapila" <amit.kapila16@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: "Peter Eisentraut" <peter@eisentraut.org>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>, "vignesh C" <vignesh21@gmail.com>,
 "Michael Paquier" <michael@paquier.xyz>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/alternative;
 boundary=421b10bf8a2e453ea5734a44a0c82e9e
Archived-At: 
 <https://www.postgresql.org/message-id/e7671bde-37e0-4ead-a9ef-8a63ac43fa99%40app.fastmail.com>
Precedence: bulk

--421b10bf8a2e453ea5734a44a0c82e9e
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024, at 6:22 AM, Amit Kapila wrote:
> On Mon, Jan 22, 2024 at 2:38=E2=80=AFPM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> > >
> > > > Yet other options could be
> > > > pg_buildsubscriber, pg_makesubscriber as 'build' or 'make' in th=
e name
> > > > sounds like we are doing some work to create the subscriber whic=
h I
> > > > think is the case here.
> > >
> > > I see your point here.  pg_createsubscriber is not like createuser=
 in
> > > that it just runs an SQL command.  It does something different than
> > > CREATE SUBSCRIBER.
>=20
> Right.

Subscriber has a different meaning of subscription. Subscription is an S=
QL
object. Subscriber is the server (node in replication terminology) where=
 the
subscription resides. Having said that pg_createsubscriber doesn't seem =
a bad
name because you are creating a new subscriber. (Indeed, you are transfo=
rming /
converting but "create" seems closer and users can infer that it is a to=
ol to
build a new logical replica.

>   So a different verb would make that clearer.  Maybe
> > > something from here: https://www.thesaurus.com/browse/convert
> >
> > I read the link and found a good verb "switch". So, how about using =
"pg_switchsubscriber"?
> >
>=20
> I also initially thought on these lines and came up with a name like
> pg_convertsubscriber but didn't feel strongly about it as that would
> have sounded meaningful if we use a name like
> pg_convertstandbytosubscriber. Now, that has become too long. Having
> said that, I am not opposed to it having a name on those lines. BTW,
> another option that occurred to me today is pg_preparesubscriber. We
> internally create slots and then wait for wal, etc. which makes me
> sound like adding 'prepare' in the name can also explain the purpose.

I think "convert" and "transform" fit for this case. However, "create",
"convert" and "transform" have 6, 7 and 9 characters,  respectively. I s=
uggest
that we avoid long names (subscriber already has 10 characters). My pref=
erence
is pg_createsubscriber.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--421b10bf8a2e453ea5734a44a0c82e9e
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Jan 22,=
 2024, at 6:22 AM, Amit Kapila wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><div>On Mon, Jan 22, 2024 at 2:38=E2=80=AFPM Hayat=
o Kuroda (Fujitsu)<br></div><div>&lt;<a href=3D"mailto:kuroda.hayato@fuj=
itsu.com">kuroda.hayato@fujitsu.com</a>&gt; wrote:<br></div><div>&gt; &g=
t;<br></div><div>&gt; &gt; &gt; Yet other options could be<br></div><div=
>&gt; &gt; &gt; pg_buildsubscriber, pg_makesubscriber as 'build' or 'mak=
e' in the name<br></div><div>&gt; &gt; &gt; sounds like we are doing som=
e work to create the subscriber which I<br></div><div>&gt; &gt; &gt; thi=
nk is the case here.<br></div><div>&gt; &gt;<br></div><div>&gt; &gt; I s=
ee your point here.&nbsp; pg_createsubscriber is not like createuser in<=
br></div><div>&gt; &gt; that it just runs an SQL command.&nbsp; It does =
something different than<br></div><div>&gt; &gt; CREATE SUBSCRIBER.<br><=
/div><div><br></div><div>Right.<br></div></blockquote><div><br></div><di=
v>Subscriber has a different meaning of subscription. Subscription is an=
 SQL<br></div><div>object. Subscriber is the server (node in replication=
 terminology) where the<br></div><div>subscription resides. Having said =
that pg_createsubscriber doesn't seem a bad<br></div><div>name because y=
ou are creating a new subscriber. (Indeed, you are transforming /<br></d=
iv><div>converting but "create" seems closer and users can infer that it=
 is a tool to<br></div><div>build a new logical replica.<br></div><div><=
br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><div>&nbsp; So a=
 different verb would make that clearer.&nbsp; Maybe<br></div><div>&gt; =
&gt; something from here:&nbsp;<a href=3D"https://www.thesaurus.com/brow=
se/convert">https://www.thesaurus.com/browse/convert</a><br></div><div>&=
gt;<br></div><div>&gt; I read the link and found a good verb "switch". S=
o, how about using "pg_switchsubscriber"?<br></div><div>&gt;<br></div><d=
iv><br></div><div>I also initially thought on these lines and came up wi=
th a name like<br></div><div>pg_convertsubscriber but didn't feel strong=
ly about it as that would<br></div><div>have sounded meaningful if we us=
e a name like<br></div><div>pg_convertstandbytosubscriber. Now, that has=
 become too long. Having<br></div><div>said that, I am not opposed to it=
 having a name on those lines. BTW,<br></div><div>another option that oc=
curred to me today is pg_preparesubscriber. We<br></div><div>internally =
create slots and then wait for wal, etc. which makes me<br></div><div>so=
und like adding 'prepare' in the name can also explain the purpose.<br><=
/div></blockquote><div><br></div><div>I think "convert" and "transform" =
fit for this case. However, "create",<br></div><div>"convert" and "trans=
form" have 6, 7 and 9 characters,&nbsp; respectively. I suggest<br></div=
><div>that we avoid long names (subscriber already has 10 characters). M=
y preference<br></div><div>is pg_createsubscriber.<br></div><div><br></d=
iv><div><br></div><div id=3D"sig112409080"><div class=3D"signature">--<b=
r></div><div class=3D"signature">Euler Taveira<br></div><div class=3D"si=
gnature">EDB&nbsp;&nbsp; <a href=3D"https://www.enterprisedb.com/">https=
://www.enterprisedb.com/</a><br></div></div><div><br></div></body></html=
>
--421b10bf8a2e453ea5734a44a0c82e9e--