Feedback-ID: ie0a040ee:Fastmail
Message-ID: <e773bc11-4ac1-40de-bb91-814e02f05b6d@eisentraut.org>
Date: Thu, 23 Jan 2025 16:40:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: SQL:2011 application time
From: Peter Eisentraut <peter@eisentraut.org>
To: Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: jian he <jian.universality@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 vignesh C <vignesh21@gmail.com>
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
 <9b7cb814-c78c-489f-85b2-32be4398647f@illuminatedcomputing.com>
 <95c6d49b-7d60-4ad0-820c-e00ae1b2a3d4@illuminatedcomputing.com>
 <57ea0668-5205-426e-b934-efc89f2186c2@illuminatedcomputing.com>
 <6dc196d4-8853-49d7-8dd3-e391058451c1@eisentraut.org>
 <bf6b3fc5-b1c2-4fdf-ad27-5de45770c58c@illuminatedcomputing.com>
 <66e47fc0-77b7-4763-9b70-5c0b7ff15f21@eisentraut.org>
 <a2ee0c1a-5ef0-43ab-897c-b56adb25b34f@illuminatedcomputing.com>
 <333d3886-b737-45c3-93f4-594c96bb405d@eisentraut.org>
 <e8e51e74-10d7-410d-a1d1-8ec681d8436a@eisentraut.org>
 <f4056005-0fb7-417a-bcb3-e704f9aeadc3@illuminatedcomputing.com>
 <6a2247d9-461d-4b0a-b692-f0f3c0fab27f@eisentraut.org>
 <8f995a4c-64e3-40cd-bfed-06b54a280d36@illuminatedcomputing.com>
 <0832f18d-523f-4c15-acb0-338a785150c5@illuminatedcomputing.com>
 <5f0c25de-2c13-4fb5-a4df-a1e03c43cd14@illuminatedcomputing.com>
 <1b45f81d-4e99-4813-a2c6-72bf5fd80980@eisentraut.org>
Content-Language: en-US
In-Reply-To: <1b45f81d-4e99-4813-a2c6-72bf5fd80980@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/e773bc11-4ac1-40de-bb91-814e02f05b6d%40eisentraut.org>
Precedence: bulk

On 21.01.25 19:52, Peter Eisentraut wrote:
> On 12.01.25 00:19, Paul Jungwirth wrote:
>> On 1/4/25 13:39, Paul Jungwirth wrote:
>>> These updates fix a problem in the unaccent contrib module. When I 
>>> added a new parameter to get_func_namespace, I changed a call there. 
>>> Then I when took out that parameter, I didn't update the extension 
>>> again. Otherwise these are the same as the v46 patches.
>>
>> Hi Hackers,
>>
>> Here is another set of commits. Based on discussion on the thread 
>> about Index AM API Cleanup [1], I decided that I should just always 
>> make FOR PORTION OF infer its intersect proc from whatever intersect 
>> op is used by temporal foreign keys (even though we don't have a way 
>> to get an intersect op for non-range/multirange types yet). This means 
>> we need one less GiST support proc, which seems like a nice improvement.
>>
>> I also fixed the RESTRICT commit where a change previously was 
>> included in a later commit that should have been included there.
>>
>> Rebased to 29dfffae0a, fixing a merge conflict + crash with the NOT 
>> ENFORCED commit.
> 
> I have committed the fix for foreign key NO ACTION (patch 0002, this did 
> not require patch 0001).  I will study the proposed fix for RESTRICT 
> (patches 0001 and 0003) next.

I think my interpretation of what RESTRICT should do is different.

The clause "Execution of referential actions" in the SQL standard only 
talks about referenced and referencing columns, not periods.  So this 
would mean you can change the period columns all you want (as long as 
they maintain referential integrity).  So it would be like the NO ACTION 
case.  But you can't change any of the non-period columns on the primary 
key if they are referenced by any referencing columns, even if the 
respective periods are disjoint.

Maybe this makes sense, or maybe this is a mistake (neglected to update 
this part when periods were introduced?).  But in any case, I can't get 
from this to what the patch does.  When I apply the tests in the patch 
without the code changes, what I would intuitively like are more errors 
than the starting state, but your patch results in fewer errors.

If we're not sure, we can also disable RESTRICT for now.  We have to get 
NO ACTION right first anyway, given the other messages in this thread.