Content-Type: multipart/alternative;
 boundary="------------2HLGlpa01Sxaz7m7rVRtFu0G"
Message-ID: <e79436ce-2321-8ec3-7eab-a8e352ec7085@highgo.ca>
Date: Wed, 15 Feb 2023 14:52:20 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: psql: Add role's membership options to the \du+ command
Content-Language: en-US
To: "David G. Johnston" <david.g.johnston@gmail.com>,
 Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <b9be2d0e-a9bc-0a30-492f-a4f68e4f7740@postgrespro.ru>
 <f388549c-4924-7142-72a5-e67c786d2a6f@highgo.ca>
 <CAKFQuwYt3ENZoYgY2RBh-U4id_=vntT9uJ83PvxPSsPQ0Cc_Jw@mail.gmail.com>
 <ee39eff0-3c0d-4367-4595-619fd1763a5d@highgo.ca>
 <CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>
From: David Zhang <david.zhang@highgo.ca>
In-Reply-To: <CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/e79436ce-2321-8ec3-7eab-a8e352ec7085%40highgo.ca>
Precedence: bulk

This is a multi-part message in MIME format.
--------------2HLGlpa01Sxaz7m7rVRtFu0G
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2023-02-15 1:37 p.m., David G. Johnston wrote:

> On Wed, Feb 15, 2023 at 2:31 PM David Zhang <david.zhang@highgo.ca> wrote:
>
>     There is a default built-in role `pg_monitor` and the behavior
>     changed after the patch. If `\dg+` and `\du+` is treated as the
>     same, and `make check` all pass, then I assume there is no test
>     case to verify the output of `duS+`. My point is should we
>     consider add a test case?
>
> I mean, either you accept the change in how this meta-command presents 
> its information or you don't.  I don't see how a test case is 
> particularly beneficial.  Or, at least the pg_monitor role is not 
> special in this regard.  Alice changed too and you don't seem to be 
> including it in your complaint.
Good improvement, +1.
--------------2HLGlpa01Sxaz7m7rVRtFu0G
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>On 2023-02-15 1:37 p.m., David G. Johnston wrote:<br>
    </p>
    <blockquote type="cite"
cite="mid:CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr">
          <div class="gmail_default"
            style="font-family:arial,helvetica,sans-serif"><span
              style="font-family:Arial,Helvetica,sans-serif">On Wed, Feb
              15, 2023 at 2:31 PM David Zhang &lt;<a
                href="mailto:david.zhang@highgo.ca"
                moz-do-not-send="true" class="moz-txt-link-freetext">david.zhang@highgo.ca</a>&gt;
              wrote:</span><br>
          </div>
        </div>
        <div class="gmail_quote">
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">
            <div>
              <div>There is a default built-in role `pg_monitor` and the
                behavior changed after the patch. If `\dg+` and `\du+`
                is treated as the same, and `make check` all pass, then
                I assume there is no test case to verify the output of
                `duS+`. My point is should we consider add a test case?<br>
              </div>
            </div>
          </blockquote>
          <div> </div>
          <div>
            <div class="gmail_default"
              style="font-family:arial,helvetica,sans-serif">I mean,
              either you accept the change in how this meta-command
              presents its information or you don't.  I don't see how a
              test case is particularly beneficial.  Or, at least the
              pg_monitor role is not special in this regard.  Alice
              changed too and you don't seem to be including it in your
              complaint.</div>
          </div>
        </div>
      </div>
    </blockquote>
    Good improvement, +1. <br>
  </body>
</html>

--------------2HLGlpa01Sxaz7m7rVRtFu0G--