Feedback-ID: i131946ab:Fastmail
Message-ID: <e79a3573-b208-f329-bf1d-89cadc7f443f@enterprisedb.com>
Date: Wed, 12 Apr 2023 23:19:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: Documentation for building with meson
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, samay sharma <smilingsamay@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Nazir Bilal Yavuz <byavuz81@gmail.com>,
 John Naylor <john.naylor@enterprisedb.com>, pgsql-hackers@postgresql.org
References: <CAJxrbyzcMM_TLtUPWkv4R+VSYJEKo-p_fCka1X69V_YHamFhpQ@mail.gmail.com>
 <20221123063654.GH11463@telsasoft.com>
 <CAJxrbyyk8jVYCvjyiQ49DOgMzB6skmDgnWjJH_LeA8v__8dOAg@mail.gmail.com>
 <20221123201620.GK11463@telsasoft.com>
 <CAJxrbyxYyrJvx2DGogw-6ZD_evyF_iW=6-_0mJAmy-3SqYAewQ@mail.gmail.com>
 <6f9c0595-1de0-ca15-b5fc-c650c3f57016@enterprisedb.com>
 <20221201172139.ua64fs5m7soyunqk@awork3.anarazel.de>
 <CAJxrbyx2nw3NvSixGqCfmfYCzQbJkSmUx95uESr9ssWJoyMCtQ@mail.gmail.com>
 <0517adcd-4fea-f20d-0a74-31f75627138e@enterprisedb.com>
 <CAJxrbywZDLXga8kz3brvDd81M6QNbTN2DHM5v7uDgSm8=RROEQ@mail.gmail.com>
 <20230411171807.ewyxv7hzcphuwcnc@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230411171807.ewyxv7hzcphuwcnc@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/e79a3573-b208-f329-bf1d-89cadc7f443f%40enterprisedb.com>
Precedence: bulk

On 11.04.23 19:18, Andres Freund wrote:
>> Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
>>   docs
>>
>> This commit separates out blocksize, segsize and wal_blocksize
>> options into a separate Data layout options sub-section in both
>> the make and meson docs. They were earlier in a miscellaneous
>> section which included several unrelated options. This change
>> also helps reduce the repetition of the warnings that changing
>> these parameters breaks on-disk compatibility.
> 
> Makes sense. I'm planning to apply this unless Peter or somebody else has
> further feedback.

I'm okay with patches 0001 through 0004.

I don't like 0005.  I think we should drop that for now and maybe have a 
separate discussion under a separate heading about that.

> 
> 
>>  From 11d82aa49efb3d1cbc08f14562a757f115053c8b Mon Sep 17 00:00:00 2001
>> From: Samay Sharma <smilingsamay@gmail.com>
>> Date: Mon, 13 Feb 2023 16:23:52 -0800
>> Subject: [PATCH v9 3/5] Remove Anti-Features section from Installation from
>>   source docs
>>
>> Currently, several meson setup options are listed in anti-features.
>> However, they are similar to most other options in the postgres
>> features list as they are 'auto' features themselves. Also, other
>> options are likely better suited to the developer options section.
>> This commit, therefore, moves the options listed in the anti-features
>> section into other sections and removes that section.
>>
>> For consistency, this reorganization has been done on the make section
>> of the docs as well.
> 
> Makes sense to me. "Anti-Features" is confusing as a name to start with.