Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMcvk-0003k2-H0 for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2016 15:47:48 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cMcvi-0006Rq-KR for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2016 15:47:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cMcvg-0006Rh-OD for pgsql-hackers@postgresql.org; Thu, 29 Dec 2016 15:47:44 +0000 Received: from 104-190-1-44.lightspeed.sndgca.sbcglobal.net ([104.190.1.44] helo=joeconway.com) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMcvS-0006nY-OL for pgsql-hackers@postgresql.org; Thu, 29 Dec 2016 15:47:43 +0000 Received: from [72.214.29.243] (account jconway@joeconway.com HELO [192.168.4.41]) by joeconway.com (CommuniGate Pro SMTP 6.1.4) with ESMTPSA id 17635014; Thu, 29 Dec 2016 07:47:28 -0800 Subject: Re: Compiler warnings To: Robert Haas , Stephen Frost References: <20161129152102.GR13284@tamriel.snowman.net> <20161206202305.GQ23417@tamriel.snowman.net> <20161206204644.GS23417@tamriel.snowman.net> Cc: "pgsql-hackers@postgresql.org" From: Joe Conway Openpgp: id=4EA5B4659ED59CC9538139A5332B7E68B699434A Message-ID: Date: Thu, 29 Dec 2016 07:47:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rxuVwMube2LMPaKjPrpB6tlL8oBa5Vgri" X-Pg-Spam-Score: -0.9 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rxuVwMube2LMPaKjPrpB6tlL8oBa5Vgri From: Joe Conway To: Robert Haas , Stephen Frost Cc: "pgsql-hackers@postgresql.org" Message-ID: Subject: Re: [HACKERS] Compiler warnings References: <20161129152102.GR13284@tamriel.snowman.net> <20161206202305.GQ23417@tamriel.snowman.net> <20161206204644.GS23417@tamriel.snowman.net> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/06/2016 01:59 PM, Robert Haas wrote: > On Tue, Dec 6, 2016 at 3:46 PM, Stephen Frost wrote: >> Good thought, thanks! >> >> Updated patch attached with that change and I also added an Assert() to >> GetCachedPlan(), in case that code gets whacked around later and somehow >> we end up falling through without actually setting *plan. >> >> Thoughts? >=20 > wfm >=20 Shouldn't this be back-patched? The plancache warning goes back through 9.2 (at least) and the lwlocks warning through 9.5 (or maybe it was 9.4). Joe --=20 Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development --rxuVwMube2LMPaKjPrpB6tlL8oBa5Vgri Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYZTAQAAoJEDfy90M199hlnSEP/3e3yE8PNkYzHjI6kZsNKUD8 e9YS0szR2nAPEEoWrCghnUoPUEYy5WN3oaCI8i1dJuy+QezVPSK763Y0vEHL0tEK bV70//tIfx+0LStvE5uHJ1vrjLrKqR28ypgMFhyWNzqImCKikaOT7PBY4hLcbAyE G9mbN6dFwsMO7VBPBhAtsMTI2wNVklNWMHZxk0F/1mUPUb6KAjO/D5ayuHFOA9wJ lt0j06t6PAWd3qcleV+OwIJ+ZfxgAr6odCWp+5lTDFqNBr7H/n5ZQ6vlNjLzLB3o WMOjPa+Sc7iMRzJo299eg6+/rP7Xus++rNKgmwxvFn0HDHIJ5Z4Xfq62WqsoqR7H zw6G82jT+qejesU+fDMrcFFApv9Gz92Tiq2YukRqEmk1Swso+Odtj9VLy97mwLqU a4EVX33E6bcvRAYitQIdCQfkRfBVwBC11ibleNv/RoH2fDf/udu7VilKmbnS46tH CcPPwyrLgxwpkcf8CGdlI8DXKVB6pKCkaqAo09lp3RdcncoYyS5pH+fUc6XGxXYI +lqM2pN1z9Y/AKY4g3qDvG2mc1/F40E9KWn80aoOCJ1rHcZfY4SFam40OJF08+09 SaAyiJB/1vTvPA4J88ib+nigSP1LF0EWBTsq8rT4VqfB+EeKLHBaHe9xr9/xQTz0 XwmAbJm78MbtmEM96nxU =wwL4 -----END PGP SIGNATURE----- --rxuVwMube2LMPaKjPrpB6tlL8oBa5Vgri--