Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fcb07-0004Zq-HH for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Jul 2018 18:35:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fcb05-0005yF-Qp for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Jul 2018 18:35:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fcb05-0005y8-GA for pgsql-hackers@lists.postgresql.org; Mon, 09 Jul 2018 18:35:05 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fcb02-0000zM-GW for pgsql-hackers@postgresql.org; Mon, 09 Jul 2018 18:35:05 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 570C021C1F9F; Mon, 9 Jul 2018 21:35:00 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.27.132] (gw.postgrespro.ru [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 255CD21C1C9D; Mon, 9 Jul 2018 21:35:00 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1531161300; bh=6v/H/3uJq/6rhusSz1CB6+qzSsOSBfA+O5pff9TmRvQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=kHZEEf94hzT8rLPQZFBjl7c77/1ulHPGYxaVhLUyxmUUyO9qnEYpyuHaiOtlTJ2NF HDHsZY3KlEGqftsrdQVGD6DFTrS3ExiLVu856ISkqYI81wR+RWVqA1ypbvlDbYFrkv ZIYRfx06Oq+d9buQ2TCMY1RJByZAKQ7wi3VlXMnU= Subject: Re: [HACKERS] PoC: full merge join on comparison clause To: Ashutosh Bapat Cc: pgsql-hackers , Jeff Davis References: <0e0a0cb9-f51e-f8a6-3829-50c3e38e33f9@postgrespro.ru> <715cb811-4538-9967-a2e3-ca85f2711d80@postgrespro.ru> <636d3f40-be16-78cc-717f-b85e9f1b9362@postgrespro.ru> <20180123163126.GK2416@tamriel.snowman.net> <53625d9e-b608-bd9d-86a2-f560c02aff7f@postgrespro.ru> <513df2b9-b068-6cf4-895e-adb3968547e0@postgrespro.ru> <8c762bb0-1507-5ac1-b408-b942416416bf@postgrespro.ru> <36d18491-579e-e54b-96bb-4cba38c5a544@postgrespro.ru> From: Alexander Kuzmenkov Message-ID: Date: Mon, 9 Jul 2018 21:35:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 07/09/2018 04:12 PM, Ashutosh Bapat wrote: > On Fri, Jul 6, 2018 at 6:31 PM, Ashutosh Bapat > wrote: >> I will continue reviewing the patches. >> > Here are some more review comments Ashutosh, Many thanks for the review, I'm glad that we are continuing with this patch. I'm working on your comments now, will post the updated version this week. -- Alexander Kuzmenkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company