Message-ID: <e7ed5a10113d04be3d02558fe6cff06a42a8777f.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Robert Treat <rob@xzilla.net>, Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@anarazel.de>, Nathan Bossart
 <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,  Michael Paquier
 <michael@paquier.xyz>, jian he <jian.universality@gmail.com>, Bruce Momjian
 <bruce@momjian.us>,  Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>, alvherre@alvh.no-ip.org
Date: Wed, 19 Mar 2025 15:17:40 -0700
In-Reply-To: 
 <CADkLM=ceOSsx_=oe73QQ-BxUFR2Cwqum7-UP_fPe22DBY0NerA@mail.gmail.com>
References: 
	<y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
	 <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
	 <CADkLM=cG8=gde_KjGiQC_wt0K3knJCy_mwvd-sW=f=3M2eSrEg@mail.gmail.com>
	 <rp6int5sqs5bn7g35brqz7w3t7il6tn2dgpm7tr3pev626wnc4@fi7a3enofhct>
	 <Z8j8HXlIIGYPA9L8@nathan>
	 <CADkLM=e-H5H+pY8iA58ie28PVSRJ1HBpzyy1=FWmy0Hm+s4boQ@mail.gmail.com>
	 <6rpmhyrtci4epuzay7y5xvd2cwdwb6zmtt6ofxrvakyawxhm7s@6grajbpr4kij>
	 <CADkLM=ct+i2G=Z+c_8np1+C75uvzjUK_SBsouUvgWMHRs2cnyg@mail.gmail.com>
	 <xe3yjkcthy7f377zjayuckxyd62z5cekgjau3j4vp6elbicson@cx2uiilwmxyy>
	 <CADkLM=f1n2_Vomq0gKab7xdxDHmJGgn=DE48P8fzQOp3Mrs1Qg@mail.gmail.com>
	 <pbjbvxnq36xo2ooufcnlfqsqnxuvggbqxbx3myjtswokshfjbl@hfihx57z4j4t>
	 <CA+TgmoYGuEC=E4TbomRyqO8+Uav=90G0dYXw=rA1d5UmRB76Yg@mail.gmail.com>
	 <bd0513e4b1ea2b2f2d06f02720c6579711cb62a6.camel@j-davis.com>
	 <CABV9wwO5v8Nu8q+xWexMdL3Z+2xS=fFJMQetBSHy3tR64wNHOA@mail.gmail.com>
	 <bec4c2feb4ef51c129ee6e1912fffa911a3c7229.camel@j-davis.com>
	 <CABV9wwP_ajEbLhCzfCO2Sy0180AshYwQFViys=QhyZA7sW2_qw@mail.gmail.com>
	 <CADkLM=dvG_F2giHEAGJ=DGVGNmujUt0vAaXNSDkDXzbzcGQbxQ@mail.gmail.com>
	 <CAJSLCQ10++5GLeoRwNMQMKuaVrikEp2X6feBv=kYDtWmsVy-Pw@mail.gmail.com>
	 <d8a3beed2682fde95936ee779e411b907df1148a.camel@j-davis.com>
	 <CADkLM=c+r05srPy9w+-+nbmLEo15dKXYQ03Q_xyK+riJerigLQ@mail.gmail.com>
	 <CADkLM=ceOSsx_=oe73QQ-BxUFR2Cwqum7-UP_fPe22DBY0NerA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/e7ed5a10113d04be3d02558fe6cff06a42a8777f.camel%40j-davis.com>
Precedence: bulk

On Sat, 2025-03-15 at 21:37 -0400, Corey Huinker wrote:
> > 0001 - no changes, but the longer I go the more I'm certain this is
> > something we want to do.

This replaces regclassin with custom lookups of the namespace and
relname, but misses some of the complexities that regclassin is
handling. For instance, it calls RangeVarGetRelid(), which calls
LookupExplicitNamespace(), which handles temp tables and
InvokeNamespaceSearchHook().

At first it looked like a bit too much code to copy, but regclassin()
passes NoLock, which means we basically just have to call
LookupExplicitNamespace().

Regards,
	Jeff Davis