From: Yura Sokolov <y.sokolov@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: C11 / VS 2019
Date: Tue, 3 Jun 2025 11:01:06 +0300
Message-ID: <e8080870-1e5d-4af8-9e19-48fedc372623@postgrespro.ru> (raw)
In-Reply-To: <aD5_OiEKEz2RpYFR@paquier.xyz>
References: <01a69441-af54-4822-891b-ca28e05b215a@eisentraut.org>
<aD2sgK4tMVumNxt4@nathan>
<aD5_OiEKEz2RpYFR@paquier.xyz>
03.06.2025 07:51, Michael Paquier wrote:
> On Mon, Jun 02, 2025 at 08:52:00AM -0500, Nathan Bossart wrote:
>> On Mon, Jun 02, 2025 at 05:44:12AM +0200, Peter Eisentraut wrote:
>>> Summary:
>>> 1. require VS 2019
>>> 2. use C11
>>>
>>> Thoughts?
>>
>> +1
>
> +1 to move on for both of these. I got convinced about the benefits
> of C11 and the simplifications we could get from it in the Postgres
> code base during your presentation at pgconf.dev.
>
> Dropping VS 2015 and going up to VS 2019 brings other benefits,
> __VA_ARGS__ coming in mind. I am wondering what's the state of
> locales, actually. We've had some pain with VS 2015 as we lacked
> locale_name in _locale_t, for example. That may be worth a second
> look to see if some simplifications can happen in this area. I don't
> think so at quick glance through the VS docs, unfortunately, but I may
> be wrong, of course..
Will it mean we can implement atomics in term of C11 atomics?
Aside for VS 2019, which has no support for. (But VS 2022 already has.)
So instead of numerous variants we could just differ VS2019 vs plain C11.
--
regards
Yura Sokolov aka funny-falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: y.sokolov@postgrespro.ru, michael@paquier.xyz, nathandbossart@gmail.com, peter@eisentraut.org
Subject: Re: C11 / VS 2019
In-Reply-To: <e8080870-1e5d-4af8-9e19-48fedc372623@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox