Message-ID: <e8257a88-3b29-4283-909d-3be1f5d9dff0@dunslane.net>
Date: Wed, 8 Apr 2026 11:14:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
To: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 Dave Cramer <davecramer@postgres.rocks>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org>
 <acI6X6YmtHnEURKL@ip-10-97-1-34.eu-west-3.compute.internal>
 <ff1b26a3-7f36-474a-93f1-bb9afcc7cf87@eisentraut.org>
 <1912638.1775510391@sss.pgh.pa.us>
 <2515f85a-217c-416e-b87e-7c480c4e1c5b@eisentraut.org>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <2515f85a-217c-416e-b87e-7c480c4e1c5b@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/e8257a88-3b29-4283-909d-3be1f5d9dff0%40dunslane.net>
Precedence: bulk


On 2026-04-08 We 8:51 AM, Peter Eisentraut wrote:
> On 06.04.26 23:19, Tom Lane wrote:
>> Peter Eisentraut <peter@eisentraut.org> writes:
>>> The first three patches have been committed.
>>
>> b4a132022 has had some not-so-desirable effects in the buildfarm:
>> drongo and hoatzin are each spewing a couple dozen repetitive
>> warnings about every bison-generated header file, eg
>>
>> src/backend/bootstrap/bootparse.h(111): warning C4255: 
>> 'boot_yyparse': no function prototype given: converting '()' to '(void)'
>>
>> Both of those machines are using bison 2.7, which is pretty old
>> and evidently isn't careful about generating complete prototypes.
>>
>> I'm not sure if there's anything to be done about this, except
>> perhaps nag the animals' owners to find a newer bison somewhere.
>> We could revert b4a132022, but then we might miss valid warnings
>> about such issues in Windows-only code.
>
> Let's try the nagging route.
>
> I found it especially curious that hoatzin is a relatively new member, 
> so why is it running this ancient Bison version?  Looking at the 
> Chocolatey packages:
>
> https://community.chocolatey.org/packages?q=bison
>
> it appears that
>
>     choco install winflexbison
>
> gives you the old version, and you need
>
>     choco install winflexbison3
>
> to get a newer version.  So it seems easy to fall into that "trap" if 
> you don't pay attention.
>
> So perhaps these buildfarm members could update their Bison version 
> sometime.
>
> I found one mention of this command in our wiki 
> (https://wiki.postgresql.org/wiki/Meson#Windows), which I updated.  If 
> we find any other documents or guides with these commands, we should 
> try to get them updated, too.


drongo is updated


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com