Subject: Re: compute_query_id and pg_stat_statements
To: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>
Cc: Magnus Hagander <magnus@hagander.net>,
 Fujii Masao <masao.fujii@oss.nttdata.com>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: <35457b09-36f8-add3-1d07-6034fa585ca8@oss.nttdata.com>
 <20210424152220.GL7629@momjian.us>
 <CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
 <20210424170908.GM7629@momjian.us> <1709439.1619286231@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
Date: Mon, 26 Apr 2021 16:46:12 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <1709439.1619286231@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e832ac41-00dd-3a05-7f52-4b2ae4613508%40enterprisedb.com>
Precedence: bulk

On 24.04.21 19:43, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>> That's a pretty weird API.  I think we just need people to turn it on
>> like they are doing when the configure pg_stat_statements anyway.
>> pg_stat_statements already requires configuration anyway.
> 
> Agreed.  If pg_stat_statements were zero-configuration today then
> this would be an annoying new burden, but it isn't.

I think people can understand "add pg_stat_statements to 
shared_preload_libraries" and "install the extension".  You have to turn 
it on somehow after all.

Now there is the additional burden of turning on this weird setting that 
no one understands.  That's a 50% increase in burden.

And almost no one will want to use a nondefault setting.

pg_stat_statements is pretty popular.  I think leaving in this 
requirement will lead to widespread confusion and complaints.