Feedback-ID: ie0a040ee:Fastmail
Message-ID: <e866a9dd-a783-4100-a152-dc3992474fb6@eisentraut.org>
Date: Tue, 19 Mar 2024 17:19:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: speed up a logical replica setup
Content-Language: en-US
To: vignesh C <vignesh21@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>, Amit Kapila <amit.kapila16@gmail.com>,
 Shlok Kyal <shlok.kyal.oss@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <TYCPR01MB12077CD333376B53F9CAE7AC0F5562@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e390e35e-508e-4eb8-92e4-e6b066407a41@app.fastmail.com>
 <TYCPR01MB12077121263EFF7680486B635F5212@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <40595e73-c7e1-463a-b8be-49792e870007@app.fastmail.com>
 <6423dfeb-a729-45d3-b71e-7bf1b3adb0c9@enterprisedb.com>
 <TYCPR01MB12077DE77454D68E959E85E35F5272@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e8564096-3c4f-4990-ac7d-ba089739b878@app.fastmail.com>
 <CANhcyEW6-dH28gLbFc5XpDTJ6JPizU+t5g-aKUWJBf5W_Zriqw@mail.gmail.com>
 <2f0b73f3-e7c0-4e95-9712-1993442a6b64@app.fastmail.com>
 <CAA4eK1JtnzqYNQ_S+mj_XsPfgk7szxegKiVQq4-8fY1wUcUnpg@mail.gmail.com>
 <34637e7f-0330-420d-8f45-1d022962d2fe@app.fastmail.com>
 <CALDaNm053p5Drh9+=VvkH0Zf_3xoLB+xw8RsNZjEwhc5xc_W=Q@mail.gmail.com>
 <96a45e74-bd83-422b-bad3-acb52d0ff5f4@eisentraut.org>
 <CALDaNm01cKLMeGYWNGO+YVyB246On=m6BW3-TEbcU+otTT8Wzw@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CALDaNm01cKLMeGYWNGO+YVyB246On=m6BW3-TEbcU+otTT8Wzw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/e866a9dd-a783-4100-a152-dc3992474fb6%40eisentraut.org>
Precedence: bulk

On 19.03.24 16:24, vignesh C wrote:
> The problem with this failure is that standby has been promoted
> already and we will have to re-create the physica replica again.
> 
> If you are not planning to have the checks for name length, this could
> alternatively be fixed by including database id also while querying
> pg_subscription like below in set_replication_progress function:
> appendPQExpBuffer(str,
> "SELECT oid FROM pg_catalog.pg_subscription \n"
> "WHERE subname = '%s' AND subdbid = (SELECT oid FROM
> pg_catalog.pg_database WHERE datname = '%s')",
> dbinfo->subname,
> dbinfo->dbname);

Yes, this is more correct anyway, because subscription names are 
per-database, not global.  So you should be able to make 
pg_createsubscriber use the same subscription name for each database.