Subject: Re: Dumping/restoring fails on inherited generated column
To: Masahiko Sawada <sawada.mshk@gmail.com>
References: <15830.1575468847@sss.pgh.pa.us>
 <fd559544-274c-f514-d8bf-358d2c539455@2ndquadrant.com>
 <31905.1575491779@sss.pgh.pa.us>
 <d6ebcc2e-3e6f-6915-6616-70ef665aed66@2ndquadrant.com>
 <24369.1580758361@sss.pgh.pa.us>
 <b1c831dd-d520-5e7f-0304-0eeed39c9996@2ndquadrant.com>
 <CA+fd4k4cHKUmEyHiPHx0QL3T-DXAP8O1CP-hUvo1WX6RwNC=tA@mail.gmail.com>
 <3f272982-0e0d-17a1-3fb6-fedc74197676@2ndquadrant.com>
 <c9848634-76c1-3c21-fc19-f1b7eebb640f@2ndquadrant.com>
 <3169466.1594841366@sss.pgh.pa.us>
 <CA+fd4k4fck6xzsF8mPWeVSZFBLtiA2cQxrPqBaYcoZGc+hZ=JQ@mail.gmail.com>
 <CA+fd4k6pLzrZDQsdsxcS06AwGRf1DgwOw84sFq9oXNw+83nB1g@mail.gmail.com>
 <e87e2efe-c820-c0d3-f7a0-0789beb78ff1@2ndquadrant.com>
 <CAD21AoCfgYKJo3cEhoUr4cKWxmSxi_gdHQDmOJ5XKC-dDc4yBw@mail.gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <e8e3f666-9050-1029-42cf-d0ecfdb8902e@2ndquadrant.com>
Date: Mon, 9 Nov 2020 11:43:38 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CAD21AoCfgYKJo3cEhoUr4cKWxmSxi_gdHQDmOJ5XKC-dDc4yBw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-11-06 04:55, Masahiko Sawada wrote:
>> Both of these result in the same change to the dump output.  Both of
>> them have essentially the same idea.  The first one adds the
>> conditionals during the information gathering phase of pg_dump, the
>> second one adds the conditionals during the output phase.
>>
>> Any further thoughts?
> I think the first one is better than the second (mine) because it can
> save the number of intermediate objects.

I was hoping to wrap this issue up this week, but I found more problems 
with how these proposed changes interact with --binary-upgrade mode.  I 
think I need to formalize my findings into pg_dump test cases as a next 
step.  Then we can figure out what combination of tweaks will make them 
all work.

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/