MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 01 Feb 2017 12:31:11 +0100
From: Erik Rijkers <er@xs4all.nl>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Fabien COELHO <coelho@cri.ensmp.fr>,
 Daniel Verite <daniel@manitou-mail.org>, PostgreSQL
 <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org
Subject: Re: \if, \elseif, \else, \endif (was Re: PSQL commands:
 \quit_if, \quit_unless)
In-Reply-To: 
 <CADkLM=fdBs+G1QrUvqu5MxW7jGg-ULZFcM3Fd2kev6fjrp7-0g@mail.gmail.com>
References: <fe2e8a9c-5a08-44d6-9767-f4dabd7c4f92@manitou-mail.org>
 <alpine.DEB.2.20.1701262143090.26793@lancre>
 <CADkLM=cr2z935TF3eB9jByWiijv-q2B7--QggfUUB12gCFFByQ@mail.gmail.com>
 <CADkLM=di=8WQRQDku6mfN=-pBqVQq_3osAARtVb6Tf0U8vyb7A@mail.gmail.com>
 <alpine.DEB.2.20.1701280721020.13068@lancre>
 <CADkLM=dm+d_FgtK4wqVkKr-X+naHXw60x+0veb04idFxYB141g@mail.gmail.com>
 <alpine.DEB.2.20.1701290916420.13068@lancre>
 <alpine.DEB.2.20.1701310658530.9372@lancre>
 <CADkLM=c8M9LDBdvijq=yXrS4ar2KLoq7uoYs0JQFmh0d3w2hmg@mail.gmail.com>
 <1084.1485886511@sss.pgh.pa.us>
 <CADkLM=fdBs+G1QrUvqu5MxW7jGg-ULZFcM3Fd2kev6fjrp7-0g@mail.gmail.com>
Message-ID: <e9580abbf2d78fa6b6b4af0a4943f5ab@xs4all.nl>
User-Agent: XS4ALL Webmail
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2017-02-01 09:27, Corey Huinker wrote:
>  0001.if_endif.v4.diff

A few thoughts after a quick try:

I dislike the ease with which one gets stuck inside an \if block, in 
interactive mode.

(for instance, in my very first session, I tried   '\? \if'  to see if 
there is more info in that help-screen, but it only displays the normal 
help screen.  But after that one cannot exit with  \q  anymore, and 
there is no feedback of any kind (prompt?) in which black hole one has 
ended up.  Only a \endif  provides rescue.)

Therefore making it possible to break out of \if-mode with Ctrl-C would 
be an improvement, I think.
I would even prefer it when  \q would exit psql always, even from within 
\if-mode.

Also, shouldn't  the prompt change inside an \if block?

thanks,

Erik Rijkers


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers