Content-Type: multipart/alternative;
 boundary="------------J97KGP1vO1LyxIG0z9L0Xnby"
Message-ID: <e97064a9-7f67-ba3d-e7e6-ff87723875d5@dunslane.net>
Date: Mon, 14 Aug 2023 15:58:34 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Peter Eisentraut <peter@eisentraut.org>,
 Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>,
 Jelte Fennema <postgres@jeltef.nl>, Michael Paquier <michael@paquier.xyz>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Noah Misch <noah@leadboat.com>, Bruce Momjian <bruce@momjian.us>,
 Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
 <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
 <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
 <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
 <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de>
 <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
 <338202.1691793002@sss.pgh.pa.us>
 <CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com>
 <342032.1691794926@sss.pgh.pa.us>
 <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net>
 <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de>
 <645add52-2ed3-970d-c9e4-a1294669fb57@eisentraut.org>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <645add52-2ed3-970d-c9e4-a1294669fb57@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/e97064a9-7f67-ba3d-e7e6-ff87723875d5%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------J97KGP1vO1LyxIG0z9L0Xnby
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2023-08-14 Mo 10:04, Peter Eisentraut wrote:
> On 12.08.23 23:14, Andres Freund wrote:
>> It's a somewhat annoying task though, find all the typedefs, add them 
>> to the
>> right place in the file (we have an out of order entry right now). I 
>> think a
>> script that*adds*  (but doesn't remove) local typedefs would make 
>> this less
>> painful.
>
> I was puzzled once that there does not appear to be such a script 
> available.  Whatever the buildfarm does (before it merges it all 
> together) should be available locally.  Then the workflow could be
>
> type type type
> compile
> update typedefs
> pgindent
> commit


It's a bit more complicated :-)

You can see what the buildfarm does at 
<https://github.com/PGBuildFarm/client-code/blob/ec4cf43613a74cb88f228efcde09931cf9fd57e7/run_build.pl#L2562> 
It's been somewhat fragile over the years, which most people other than 
Tom and I have probably not noticed.

On most platforms it needs postgres to have been installed before 
looking for the typedefs.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------J97KGP1vO1LyxIG0z9L0Xnby
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-08-14 Mo 10:04, Peter
      Eisentraut wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:645add52-2ed3-970d-c9e4-a1294669fb57@eisentraut.org">On
      12.08.23 23:14, Andres Freund wrote:
      <br>
      <blockquote type="cite">It's a somewhat annoying task though, find
        all the typedefs, add them to the
        <br>
        right place in the file (we have an out of order entry right
        now). I think a
        <br>
        script that*adds*  (but doesn't remove) local typedefs would
        make this less
        <br>
        painful.
        <br>
      </blockquote>
      <br>
      I was puzzled once that there does not appear to be such a script
      available.  Whatever the buildfarm does (before it merges it all
      together) should be available locally.  Then the workflow could be
      <br>
      <br>
      type type type
      <br>
      compile
      <br>
      update typedefs
      <br>
      pgindent
      <br>
      commit
      <br>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>It's a bit more complicated :-)</p>
    <p>You can see what the buildfarm does at
<a class="moz-txt-link-rfc2396E" href="https://github.com/PGBuildFarm/client-code/blob/ec4cf43613a74cb88f228efcde09931cf9fd57e7/run_build.pl#L2562">&lt;https://github.com/PGBuildFarm/client-code/blob/ec4cf43613a74cb88f228efcde09931cf9fd57e7/run_build.pl#L2562&gt;</a>
      It's been somewhat fragile over the years, which most people other
      than Tom and I have probably not noticed.</p>
    <p>On most platforms it needs postgres to have been installed before
      looking for the typedefs.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------J97KGP1vO1LyxIG0z9L0Xnby--