MIME-Version: 1.0
Date: Thu, 03 Apr 2025 08:38:18 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Alexander Korotkov
 <aekorotkov@gmail.com>, pgsql-hackers@lists.postgresql.org, Ronan Dunklau
 <ronan.dunklau@aiven.io>
Subject: Re: SQLFunctionCache and generic plans
In-Reply-To: <1101294.1743617356@sss.pgh.pa.us>
References: <8216639.NyiUUSuA9g@aivenlaptop>
 <3084885.1675783797@sss.pgh.pa.us>
 <b69515864a7021505340f85476dc111e@postgrespro.ru>
 <CAPpHfdue9RVJKo33jKwrCeEXec0BTTH7CTxVcyXGMbfMExaGLA@mail.gmail.com>
 <758251661a3e8760ff52dd5c672a7505@postgrespro.ru>
 <CAFj8pRCoR9B+Ap70TQqWUa0PeeEk94D6VW20YbWN2Pm4b6-JMQ@mail.gmail.com>
 <30f02ca545915627905fbe3f23d93ec1@postgrespro.ru>
 <2275997.1737138456@sss.pgh.pa.us>
 <ad7296dd981c5f8eb76ff129913a55fd@postgrespro.ru>
 <51ebc5f3b846ce279b75ac4f5e5ac33f@postgrespro.ru>
 <CAFj8pRD2Fa84HoH_R_S5aKngyA6a+Au7U6NyidfBMrwEjFAc9g@mail.gmail.com>
 <401652.1738598448@sss.pgh.pa.us>
 <CAFj8pRC_4gEfmDoB5KbacNDdt3e6Tnf1z1BFK=MVp3+2kcDVqw@mail.gmail.com>
 <CAFj8pRA7MFTfUPwDDWtghaUvAjbrMHFUPbHyLSX3h8+FDw4WFg@mail.gmail.com>
 <445556.1738612687@sss.pgh.pa.us> <464677.1738620525@sss.pgh.pa.us>
 <1fc18af56d5fb27bf3e153ffaa2ed70d@postgrespro.ru>
 <2615770.1740688857@sss.pgh.pa.us>
 <448c63cf9b4f917c01802309b9c29eb9@postgrespro.ru>
 <CAFj8pRDWDeF2cC+pCjLHJno7KnK5kdtjYN-f933R! ! ! ! !
 HS7UneArFw@mail.gmail.com>
 <CAFj8pRD0diy5VDP=8B9au5sk_yRknCWqZx35VniBtP_OA4aJNw@mail.gmail.com>
 <2827970.1741890560@sss.pgh.pa.us>
 <337e011069b6831e063bfa346f49bb46@postgrespro.ru>
 <3344719.1741985546@sss.pgh.pa.us>
 <fcc68b0ef570160cd6e88851eb244ccd@postgrespro.ru>
 <db42573039cc66815e80a48589eebea8@postgrespro.ru>
 <2691107.1743257329@sss.pgh.pa.us> <3605427.1743351017@sss.pgh.pa.us>
 <248291.1743463745@sss.pgh.pa.us> <1101294.1743617356@sss.pgh.pa.us>
Message-ID: <e9a2104f9efabf678ddc9c0a78d62189@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/e9a2104f9efabf678ddc9c0a78d62189%40postgrespro.ru>
Precedence: bulk

Tom Lane писал(а) 2025-04-02 21:09:
> I wrote:
>> Anyway, I feel pretty good about this patch now and am quite content
>> to stop here for PG 18.
> 
> Since feature freeze is fast approaching, I did a tiny bit more
> cosmetic work on this patchset and then pushed it.  (There's still
> plenty of time for adjustments if you have further comments.)
> 
> Thanks for working on this!  This is something I've wanted to see
> done ever since we invented plancache.
> 
> 			regards, tom lane

Hi. I've looked through the latest patch series, but didn't have much 
time to examine them thoroughly.
Haven't found any issue so far. From cosmetic things I've noticed - I 
would set func->pcontext to NULL in sql_delete_callback() to avoid 
dangling pointer if we error out early (but it seems only to be a matter 
of taste).
-- 
Best regards,
Alexander Pyhalov,
Postgres Professional