Message-ID: <e9e025ca-bf2b-cdcd-3283-3bc7e5ef6d53@gmail.com>
Date: Fri, 3 Mar 2023 17:28:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and
 xl_btree_delete
Content-Language: en-US
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>
References: <80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com>
 <86b7297e-13c0-dca0-a723-c687e3878608@gmail.com>
 <CAA4eK1LhiZ7B-LNTAOBzx38SrnGFGA7kBf65vmUOWRa8sMJ-6Q@mail.gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <CAA4eK1LhiZ7B-LNTAOBzx38SrnGFGA7kBf65vmUOWRa8sMJ-6Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/e9e025ca-bf2b-cdcd-3283-3bc7e5ef6d53%40gmail.com>
Precedence: bulk

Hi,

On 3/3/23 12:30 PM, Amit Kapila wrote:
> On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
>>> Hi hackers,
>>>
>>> Please find attached a patch to $SUBJECT.
>>>
>>> The wrong comments have been discovered by Robert in [1].
>>>
>>> Submitting this here as a separate thread so it does not get lost in the logical decoding
>>> on standby thread.
>>>
>>> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
>>>
>>> Looking forward to your feedback,
>>>
>>> Regards,
>>>
>>
>> It looks like I did not create a CF entry for this one: fixed with [1].
>>
>> Also, while at it, adding a commit message in V2 attached.
>>
> 
> LGTM.
> 

Thanks for having looked at it!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com