Feedback-ID: ie0a040ee:Fastmail
Message-ID: <e9eeb485-8837-4182-9183-2b2380178a3f@eisentraut.org>
Date: Wed, 17 Apr 2024 15:29:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: some LLVM function checks missing in meson
To: Heikki Linnakangas <hlinnaka@iki.fi>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <c38977be-398d-4333-9ef5-3617655c00e9@eisentraut.org>
 <5539b16c-cff7-46d5-9621-c3fb6b549e9e@iki.fi>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <5539b16c-cff7-46d5-9621-c3fb6b549e9e@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/e9eeb485-8837-4182-9183-2b2380178a3f%40eisentraut.org>
Precedence: bulk

On 13.04.24 10:25, Heikki Linnakangas wrote:
>> Something like the below would appear to fix that:
>>
>> diff --git a/meson.build b/meson.build
>> index 43fad5323c0..cdfd31377d1 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -2301,6 +2301,14 @@ decl_checks += [
>>      ['pwritev', 'sys/uio.h'],
>>    ]
>>
>> +# Check presence of some optional LLVM functions.
>> +if llvm.found()
>> +  decl_checks += [
>> +    ['LLVMCreateGDBRegistrationListener', 'llvm-c/ExecutionEngine.h'],
>> +    ['LLVMCreatePerfJITEventListener', 'llvm-c/ExecutionEngine.h'],
>> +  ]
>> +endif
>> +
>>    foreach c : decl_checks
>>      func = c.get(0)
>>      header = c.get(1)
>>
>> I don't know what these functions do, but the symbols are used in the
>> source code.  Thoughts?
> 
> +1. I also don't know what they do, but clearly the configure and meson 
> checks should be in sync.

Committed that, too.