Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly73l-00072X-An for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Jun 2021 06:17:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ly73k-0006kP-8F for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Jun 2021 06:17:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly73j-0006kG-El for pgsql-hackers@lists.postgresql.org; Tue, 29 Jun 2021 06:17:24 +0000 Received: from wforward1-smtp.messagingengine.com ([64.147.123.30]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly73c-0002Tz-DW for pgsql-hackers@postgresql.org; Tue, 29 Jun 2021 06:17:22 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.west.internal (Postfix) with ESMTP id 6BC6C1AC07AB; Tue, 29 Jun 2021 02:17:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 29 Jun 2021 02:17:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VEseQYyGKQA+uG9soc82ZSjl/qmf+e/6oFG3bCMs3 M0=; b=iKYMn+C4gB7ghSYRVj+VrhM9vFDAsD1hc/iGCRUtSxpWo4yn/yBcBUUvt U2T0av5xXz8/p8CGMkLcq366F6VRmC/cxGFg0m4MijXeBTL3irgmsfXKLXS5WQg+ mJh4OCokDhznmavNDtdA3rkupLrhY/0h1hhWRzvnv0VqPViif42kkUf/BN6kADme W+tr1Ojn6xyp2fyJCa73VhaZjLIXMMrJweceNP17Ysr5SjUA7PT+aBYW84jiNPDu IQyI4GVdyWhIMfoeX+VHqiFJKM8Ga8HsXtR7UyC7groiUrpl2vNQIimOUGYMwICg 5G8p7c8MrS2QSxIlpbEAN7pbDvuSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehhedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekheeihedvgeeugefh ffeuleeivdfgiefghfehvedvgeefgfefteegjedujeejheenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Jun 2021 02:17:13 -0400 (EDT) Subject: Re: Add index OID macro argument to DECLARE_INDEX To: John Naylor Cc: pgsql-hackers References: From: Peter Eisentraut Message-ID: Date: Tue, 29 Jun 2021 08:17:11 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 21.06.21 13:53, John Naylor wrote: > > This patch changes places like this > > > > DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650, on > > pg_aggregate using btree(aggfnoid oid_ops)); > > #define AggregateFnoidIndexId  2650 > > > > to this > > > > DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650, > > AggregateFnoidIndexId, on pg_aggregate using btree(aggfnoid oid_ops)); > > +1, and the patch looks good to me. committed, thanks