Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFCdv-0006Xh-AH for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Feb 2022 10:13:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nFCdt-0002AA-1E for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Feb 2022 10:13:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFCds-0002A0-J3 for pgsql-hackers@lists.postgresql.org; Wed, 02 Feb 2022 10:13:36 +0000 Received: from hook.sigaev.ru ([93.180.27.50]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFCdp-0000xX-0s for pgsql-hackers@postgreSQL.org; Wed, 02 Feb 2022 10:13:35 +0000 Received: from [192.168.1.8] (128-72-215-18.broadband.corbina.ru [128.72.215.18]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: teodor) by hook.sigaev.ru (Postfix) with ESMTPSA id DCA70B191F0; Wed, 2 Feb 2022 13:13:29 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------9R98o845OkMCwLpcJ7yWKGki" Message-ID: Date: Wed, 2 Feb 2022 13:13:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: CREATE TABLE ( .. STORAGE ..) Content-Language: en-US To: wenjing zeng Cc: pgsql-hackers References: From: Teodor Sigaev In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------9R98o845OkMCwLpcJ7yWKGki Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi! > Are they both set to name or ColId? Although they are the same. > Thank you, fixed, that was just an oversight. > 2 For ColumnDef new member storage_name, did you miss the function _copyColumnDef() _equalColumnDef()? Thank you, fixed > > > Regards > Wenjing > > >> 2021年12月27日 15:51，Teodor Sigaev 写道： >> >> Hi! >> >> Working on pluggable toaster (mostly, for JSONB improvements, see links below) I had found that STORAGE attribute on column is impossible to set in CREATE TABLE command but COMPRESS option is possible. It looks unreasonable. Suggested patch implements this possibility. >> >> [1] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfnyc-2021.pdf >> [2] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgvision-2021.pdf >> [3] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf >> [4] http://www.sai.msu.su/~megera/postgres/talks/bytea-pgconfonline-2021.pdf >> >> PS I will propose pluggable toaster patch a bit later >> -- >> Teodor Sigaev E-mail: teodor@sigaev.ru >> WWW: http://www.sigaev.ru/ > -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/ --------------9R98o845OkMCwLpcJ7yWKGki Content-Type: application/gzip; name="create_table_storage-v2.patch.gz" Content-Disposition: attachment; filename="create_table_storage-v2.patch.gz" Content-Transfer-Encoding: base64 H4sIAD5Z+mEAA+1ae3PaSBL/Gz7FnCt7i80b84wd37I2yVKLjRfw3qZyKWqQBltnIRFJxKbi fPfr7hmhEQiDc6m92qpzKkia6enp6f71Y0YyremU5fO3VsB40XSNou/B/9uZXfTEtGh4ggdi HPCJLQrYyiZ7EKUtxxSPbNJqTCYtU5jlWqFglKpTXmlMSqbByqVSvVpN5/P5veZMZ7PZ/eb9 6SeWr1RyDZalX3i8dv3g1hPD33oMxi9mwgl4YLlOmrFT4OEvHXfuW75pfT5Ls9PwEe7PB532 qMM+wL93vf7P7R57Yr3+OVw/si9s1Lm87g/ag/fQivfsK9zcXPX67951LoBi1P65h4O7b9lV f8Q6f3SHoyG0w5xzmxsCRWaGzX3/zcGce3wmAuEdnNFSxg48nhY1yjOWYR/SeQYT72BguPZi 5iRx2DHQ5AEfB8v5+rAP7Lx/eT3oDIfd/lWMCcw1m3vC90GbY+By55prYz/S6F4P9bg20rbJ CgkD9lug4Tp+4HHLCTbkLRQKwOhjOvu/UddwBLh414G5r3vt7hXAovPHqDO4IgDh7dUFIOSJ XWLnV6Wjv6aGGf49xSeWCN42OBzS6/66JrDvLjxD+fLGhDFK27oXY3eesDgp11c5yYecfJYx oVXJ1SEowKXSxLDwz+7oF3Cqy/7FTe9muEslDsQNzzLGtgWP3I5Pm2ODzqWc87RoW34ARDO5 0tPiZ+5hE0QdbwltCEp2Gm/MEiUwngHq1Axnw87ohUjCueXY0yIxU4wjibJSRlxX+MBGd5bP pq43Y74IfBbcCeYHrsdvBZu5psAuxpmEREFSg20Dz7V99nAHkBQeDLL8kJ+kZEB2J2yTWY5t OYIBE8sBPr6AwSb3luyUG57rLGdno357ODotho+MAJBj3DFDltE0gqHbhe3+nbuAKSZgMOUm wsSZHDcoRIok1UW6YbOFH+CYBVCHnHCRU+tRmHlbOLfBHfvM7YXwmb8w7hj3wTjg6GcAZnEr PNAuPqGELFq3XGiOLZxIGE2Ky7gQUufhoEh3ytsRhLhSjUFo+U0m4hGeHW6v2OgiEBvSZpwV ImcPVmuMCmwXF7KRmPKFHRDHGWTfkBlyYKg7JOMBaHc+d70A7OXkt5pLgbEQMrnxAU3TZ/Xy YNk2m/F7QPJiAlHIcm6ZO4c+jBg+g9SveH0WAESbe4B1aeEAFKCbV7ZOloHgYbNChrdw2JSD C3srXcGKcPVzAQoMliik5WCBgsoLXcqfQ9AosHDIUMDMj1CFMMDBvXDMNweKMh+4wP2geKa0 6Anghm5Kiwi1cVrUfFmPPdmE2JOVEWktIEWxZ6XSbdkoMVU8n582YxJbi0mmXn1icTfhBmqi CKxnYAO/SAHBmJl+wYAacBeJqjyrNVFriWOzZtQLhbLZbLbKrVKjVolXnjuZybpzJxlmmHqp gRkGL1R3+lhmGuyza5kMLAzh5mIxF12Urh0E3LjLDITM0AwUCubomo+QSbQ2akmHjHqgMnb0 TgTXRC3MtwAK69b5VSwHUMbGuIFu4e7wJB2Toj26EDjx+Z0w7q/cl4w37rjHYG6Q3LMmi0Cc R4bP9IE3DwLwD8vMSdIjDRjAJquxSelshhLtGSoX1FDlAZh9UAL8VzwCiPx3f2SjVqmGNmqV 6rlKBY10IaYQgMOlZ85pPzEMZgGKMQvUajxh3wOscgxX6j44wuuaYJhUypoyEN0GLnndFQ6x LwUq8fJn8Kv1sDdbtbgil3okFtqfTK0bM4Fu09m4IEp/VNMeYucX/InECWNRXJTIEglcTohD 8Ygu7Ij5fCogxBkIpNewrcKUy7htuw+M4pYW8dCMPqQkGwQOiwNMBBhNQ3aQN6gKyPMHwHZB NRfpiiv7W2ZT+Dds9P5aFUhjVR490QhQ1QiYd/0RioJeuqbbw8NDSSggVEECynQGg/4gJ9tS qYzwPAOkxubz/kVn/Bb2gTeDzhj2cePhzTVs+0adi8MVPQP6mX+bOdBWR2mO/QAr5g4kHHvJ 7vjnqLIieQ9WHFIpGdlpPzGeJMgrLfAVYzj8gkegMSjqNGpl3O3WG/VmrnKMmIatwKMw2qZ5 TvJkZOA4evi0EAsoUNo2BGJhjlAxXUgp7Ah0pAUeADuCj4fAKEgxwI6AGHlzst4/WUJaxG5c R/4MqKhlg47bEHBidNRyks7H6SKIRpSqDRXxHNoJ7FuYvQzvEu7fF+3JYFdYj6C+Kft2uCej XTddhPhEwL8Q798B7glo35CXbACATwnbF8/YNAkg67DbLwCjOP3NyLs18K5NAqBwFjZ6QUhu +WNoHGPrCTlrs1IpobM2K7VjyEPQNBQBVQQKjdce1qmBJbR0jP4YeSdOqe6j0qA/+bcwAvB4 FC6tAgCwDjEe56XnWhD1CgCfY1e41ztyxMPvWN/m8KDrV9gbd5jtGveUitPsC7gpZXBQiZ6l URXUnoLxKyuwVDhtShMa238RfD5azG2RCvB3pZtWrlJF5dTLuWYUyL7fOmDqmKYYl1cqMlJt 2OWAa3T9diYaPqTdA4Ixn9JWDEaGfQXQrEipUsmTC89vx9BpQN1vzOYZbVSOHUBlbDkHh+jP pUOg1zTGNl0cZ0X4s11sw33bPpzDDdOLmANGzX2Z46Zwb+azPfVxqakDLgjF9WiWTwxm3avf 273uxfi6PWhfdmDpY3i+6Rwq+lU0sxxIWFYUySmi/evgB/9fBweKNqVD4FCCIi5w6YTKJHYv xJz2zpYtPPZpYYkAY3yeAlpsRFJKWoeWrIJ1L8K4R8dsEC6czIpB6B9QnbKB+9B5NOyFb30W PfBhYoKOVm62ao3cMcvCTeMYXQ5av7W0J8E8ESw8hxlyAwjzYJ2il/zp7Etq/nT2i8rx+3sS 5AclxaYPZb/RhxJ5Rt7zArYx79nKVvrNnmxnO1d/qS0+rIuS8v8LPCb7Ao/JJntMJOoOX6Hk /3X78YCDlRbsxufL6cIxNs8GNvrVwYA5LU0a1UazedwsFErgCvVyfdLk1e0HA5ucNk8FNmnQ 1Y5L1RLuN+lKhwJjJJF1OZQIygVWz+xo6rkz3D2e96/fj4fn7V57MH7b7fQuMloxQbVHIgUO p7JqC4myBtlB9o4G3at38d6wBFYMrqgkJAKPP4zV4V5iv+G698LcJImLaQonsIIldO8wrvi0 4PZz1tUJlHmNScM0zWr92JgUCrxUrxj1pqg2m7vMG2O1zb4xInqrUG9W6bUCXqWBieYZC/Ow cNHaJtLkl+BxnV1WTyZaN3wCVdz2imCH+SXVswjYIEkEQZLUe+Bgzj0oyoq3Hp8VlmsmifUp 61f4cbklhGHyUqHQKJXKZVFrmTW+3fpxLpuGj/ejzWtNer0sL9E5nyw88dR5IIyFh2n3d0s8 DIUNBWdGZjlI3w5VqXJLDtETYrsfFq2wP/eWMtf/QLH0FFF3lqKd+vnqfRqj5551L85tvoDY HlJbEI4VNfb26QUZzbTWls6rEcDxLJVave6LNknuPBhvNqez3zZOb1YgWwmNB8FnKfCF38Bt UNi1xUOPtvTYU8cWMxY9Yn2xpot7sRzDRtO4k856XG7QhwHyCk0cj0LG6oXlzHytdn6vXkF9 lZFGOaQdSwrPXpjMV+0epET1ev8UzXmmmj6c93s3l1cf2SmsVXboL/FOtVR4JqvBVOpJjY00 hGvsmrGR1EIJdS9ynFrK/EUtiI58JIxmJuyOYHkIVFxhJtZ3qBabcvJn/mJCunwD+7BxtAmT u7Xjaus4V65AaqMbOnfCYwh5rISWAeeW+nxiawCmCb4w0vKr8gkjzdL2yQhD4uuUXBayxOVs A5b6/uNWOPR2Vr4T9pkOp+xeTMMa5tvniSlci+0xZa/adUUrtEhtRM2o/CvVXjlROxAndgiB XccnqtRy4mdY631rw6raTJZzZ7gLcC/cwGjN/hg2zfJcz1uIeE+YlaBzyqHCVLColRqwd8/C tSn38N/bpJEQWioCIa5uer2YTvUklNRv27i3ecO6soqFB03HU/MhnFjqSvYM57YVaEbPvKrl 2N+JXQhuP2ywbRmec5EJ4lxroXE2udb34BodUrHl0je4A/rSUYWmU1vFn1awWo9s0mb1YypS a/VqrlxGoyWbJnTn4lHn8nr0/qgYCqB8mVQceXN2071e04pVnEohCuIcAOe4d9xrlizOkk3r PigF1Bri+UJjYvM5oNDMvCrnYNJDJfVzs3Zp0o1CxXJgi20KVR9SsUC3hTtVR2wnCF9UGjXe 5MetybRcKNSMSqU1FdNao7xZsjzDKqpbniFSrwvoJSVcKANikAEnwdOshaHVpKCOievaqZR+ honZD79lQxOwCJzMnwvDmlrC/AemNW3kqiqloeF5Mb5yo/eLzMA4gETyNEPuIImFPE4MzxIp 72qnvr4IAsu5zeHHHiV6QR46Om0c5eAjPRqeJHNgMhJ5ckkaIxIC/YTOOrVQQ4zC2ehbAJaB 0Olxx8eDaGEy0jlETCEOWZxNPCidsE1OOh/xOPd0NnJVYdW80knYsFoSEG/ANBB+UPTELXpy ERhDSSrMolb+FNxFoBC0F21Yb1fNstEwzEoT6u1ptVYricYEoLwJ3v24Rjjej15+7Xlclt97 0jUs6xSkPCzGy3jSG+JvWmEAWohQSWTUFBESIKkPIhOsZcot208zOj55Lb+OcX0rEBphGd+B 4AuiiYC8D4GWs5mYTYAtfhAS+MIG5wJWesU240vmCLB54JKkXL4hkrJBWUQpMfQRUMyqXMlw hp+s4J5uJxHsO+m6Oq+hE7TDNUXERsoO/GprbdSzg2ABE1TxCtwl0p0nHjwrktCFhpn7WaBO Yst9mTjh8ZqaIo+z69wkQqqU4ejaQoQ83AkP/J4KgB/1OX58/RpAR9+5wBoZlHWZMvPcBzzo zObz9ApwZTbD9cDkgYMvXbbrf4ygAduuzCCVs74AtGGEq7U3a+rLs+derxGocF75bZUOr7nn zvktSOej2tU5iZTdXqZVxaXaY5Jb5iNMt4amSY7xPVCj1rBpLTxjPVF2qZWlXWrVTc99OU+m 8hd7ku9E6UPT8/A7WLi/gixGvJ/www/C5hNT+xpGtxw/gcQPwgKi8Q3PooqNpVcfoGTzm3ex +0QCnXbjESTnTH0YSy5Kd9HfU9Lt02rlMVrqSWfB2V/OkHx7nVYyZABbdR+CcSvD0l4M6b2n 8F/LL8IO1oF3wCaY/BTedqQ0/5Mdyw3wnJRHEshUIqtNuVGpNWtmCxJZvW6WzGmtVasnVGE7 GW7JYUmk9DqmVq5j+lLXPyN9/T///Ln5p1yrUNVNV8o/Pp0K4mts+oAErpCKTs/Ac7gPsd0f U/NYCUQV8vx2TGkpvW/y+hPy1V8s5/wHMy1QU+k0AAA= --------------9R98o845OkMCwLpcJ7yWKGki--