Feedback-ID: ie0a040ee:Fastmail
Message-ID: <eb076b15-64b5-4992-b232-9e00603e0849@eisentraut.org>
Date: Mon, 12 Feb 2024 16:18:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: table inheritance versus column compression and storage settings
Content-Language: en-US
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <24656cec-d6ef-4d15-8b5b-e8dfc9c833a7@eisentraut.org>
 <CAExHW5uH0q810ZZ7ZP2Bvz_aF33yPTUsZ5NNC=yvA1MsVVtDTw@mail.gmail.com>
 <38546838-8a60-4d50-ba8e-b2c7cf2cb64b@eisentraut.org>
 <CAExHW5uAqaO7RcDgBiwm2pVO58evFY8AKzvVks-2dn3FKyWUkQ@mail.gmail.com>
 <CAExHW5sVAMNBNeD8-nih8HY8n4ySJWe9Uf+QNRTMOD7u-De-CQ@mail.gmail.com>
 <CAExHW5v+Au_kadPJd7ifmKLzFu+fbtkDp5duuzuS6bZdLJsD1w@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAExHW5v+Au_kadPJd7ifmKLzFu+fbtkDp5duuzuS6bZdLJsD1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/eb076b15-64b5-4992-b232-9e00603e0849%40eisentraut.org>
Precedence: bulk

On 08.02.24 08:20, Ashutosh Bapat wrote:
> On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> 
>> 0001 fixes compression inheritance
>> 0002 fixes storage inheritance
>>
> 
> The first patch does not update compression_1.out which makes CI
> unhappy. Here's patchset fixing that.

The changed behavior looks good to me.  The tests are good, the code 
changes are pretty straightforward.

Did you by any change check that pg_dump dumps the resulting structures 
correctly?  I notice in tablecmds.c that ALTER COLUMN SET STORAGE 
recurses but ALTER COLUMN SET COMPRESSION does not.  I don't understand 
why that is, and I wonder whether it affects pg_dump.