Subject: Re: remove some STATUS_* symbols
To: Michael Paquier <michael@paquier.xyz>
References: <a6f91ead-0ce4-2a34-062b-7ab9813ea308@2ndquadrant.com>
 <20200106063159.GQ3598@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <eb176922-2b1f-86d1-9ed4-e2c60a39b956@2ndquadrant.com>
Date: Thu, 9 Jan 2020 11:15:08 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200106063159.GQ3598@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-01-06 07:31, Michael Paquier wrote:
> On Sun, Dec 29, 2019 at 11:33:34AM +0100, Peter Eisentraut wrote:
>> Attached are two patches to remove these two symbols.  STATUS_FOUND can be
>> replaced by a simple bool.  STATUS_WAITING is replaced by a separate enum.
> 
> Patch 0001 looks good to me, but I got to wonder why the check after
> waitMask in LockAcquireExtended() is not done directly in
> LockCheckConflicts().

You mean put he subsequent GrantLock() calls into LockCheckConflicts()? 
That would technically save some duplicate code, but it seems weird, 
because LockCheckConflicts() is notionally a read-only function that 
shouldn't change state.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services