Subject: Re: snapbuild woes
To: Andres Freund <andres@anarazel.de>
References: <20170413002959.apytyi5lkknauauj@alap3.anarazel.de>
 <0d06dfc1-0bc5-c3ab-3555-24e2f275d7fa@2ndquadrant.com>
 <30242bc6-eca4-b7bb-670e-8d0458753a8c@2ndquadrant.com>
 <20170501005921.qcqd7w2njpv3av6s@alap3.anarazel.de>
 <20170501013529.sejtgo2acxbvq26q@alap3.anarazel.de>
 <209861fc-718f-0a7b-3a1d-36512865c209@2ndquadrant.com>
 <20170501080348.vb6mj5whdex3f7l7@alap3.anarazel.de>
 <e6c1fdfe-50bc-62e4-3ad7-854f6ac5c35e@2ndquadrant.com>
 <20170501191419.coqbtx2jodu22ufz@alap3.anarazel.de>
 <ba7a3052-6e71-d162-d4a0-b5bdd7145c19@2ndquadrant.com>
 <20170505000004.gihrtl7bhxeolf3q@alap3.anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Erik Rijkers <er@xs4all.nl>, Robert Haas <robertmhaas@gmail.com>,
 Craig Ringer <craig@2ndquadrant.com>
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Message-ID: <eb253506-8e8a-a4a4-41ff-a530e65d358b@2ndquadrant.com>
Date: Fri, 5 May 2017 13:10:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170505000004.gihrtl7bhxeolf3q@alap3.anarazel.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 05/05/17 02:00, Andres Freund wrote:
> Hi,
> 
> On 2017-05-02 08:55:53 +0200, Petr Jelinek wrote:
>> Aah, now I understand we talked about slightly different things, I
>> considered the running thing to be first step towards tracking aborted
>> txes everywhere.
>> I think
>> we'll have to revisit tracking of aborted transactions in PG11 then
>> though because of the 'snapshot too large' issue when exporting, at
>> least I don't see any other way to fix that.
> 
> FWIW, that seems unnecessary - we can just check for that using the
> clog.  Should be very simple to check for aborted xacts when exporting
> the snapshot (like 2 lines + comments).  That should address your
> concern, right?

Right, because there isn't practical difference between running and
aborted transaction for us so we don't mind if the abort has happened in
the future. Yeah the export code could do the check seems quite simple.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers