Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1gFL-0000uT-An for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Nov 2016 21:05:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c1gFK-0006tu-PD for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Nov 2016 21:05:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c1eje-0007Jm-6R for pgsql-hackers@postgresql.org; Tue, 01 Nov 2016 19:28:38 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c1eja-0003IF-QW for pgsql-hackers@postgresql.org; Tue, 01 Nov 2016 19:28:37 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DD6EA206D9; Tue, 1 Nov 2016 15:28:32 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Tue, 01 Nov 2016 15:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-me-sender:x-sasl-enc:subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=smtpout; bh=lozmItiKf Gd107gMvL5d3dP5TqI=; b=mNHkRTuqJvdveFROThwqqFh7MlWrH1hmCYB7hMt7A fAzJpHMm18udPtGdHrWCyf2QWVvNnCx1hQ5ci/EKmFsfUNehlPK93Mg58CkPQg1v 8uULHxAHhwtyZXRmiyk6Vnv06/bssUyeATDwiPwHqN7MihWWbmb/0AT2Vj3Bt1Lj Dg= X-ME-Sender: X-Sasl-enc: p2eNKKN5gEKjm68JZ6HC4UMIqPfJqyq3zRh9KOwdDUCV 1478028512 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C36BF29CE; Tue, 1 Nov 2016 15:28:32 -0400 (EDT) Subject: Re: pageinspect: Hash index support To: Jesper Pedersen References: <5d64a536-cc90-ce96-b68f-5b6bd3206476@redhat.com> <80a00b5c-56d3-dffb-8dba-edf5d2167b12@2ndquadrant.com> <16d89e7e-cb1a-cb5d-e944-6f10c324a312@redhat.com> <836487ee-8d4e-cd49-54ac-f4793ddba5ae@redhat.com> <8a751498-6ee9-b943-abf3-b5641851d7de@2ndquadrant.com> <62ee2eba-3a5b-06d3-e224-cfe00b395be7@redhat.com> <66afc31d-e97a-41c3-da4c-bfa02fa2d54e@redhat.com> Cc: Michael Paquier , Ashutosh Sharma , Jeff Janes , Alvaro Herrera , PostgreSQL Hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Tue, 1 Nov 2016 15:28:32 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <66afc31d-e97a-41c3-da4c-bfa02fa2d54e@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 10/3/16 8:52 AM, Jesper Pedersen wrote: > On 09/29/2016 04:02 PM, Peter Eisentraut wrote: >> On 9/29/16 4:00 PM, Peter Eisentraut wrote: >>> Since the commit fest is drawing to a close, I'll set this patch as >>> returned with feedback. >> >> Actually, the CF app informs me that moving to the next CF is more >> appropriate, so I have done that. >> > > Ok, thanks for your feedback. > > Maybe "Returned with Feedback" is more appropriate, as there is still > development left. I have applied the documentation change that introduced subsections, which seems quite useful independently. I have also committed the tests that I proposed and will work through the failures. As no new patch has been posted for the 2016-11 CF, I will close the patch entry now. Please submit an updated patch when you have the time, keeping an eye on ongoing work to update hash indexes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers