Subject: Re: language cleanups in code and docs
To: Magnus Hagander <magnus@hagander.net>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de>
 <CABUevEy0vPwsuQ8K_=xLW6=4hFoVCvdxtDpr14FXW55i=8CZYw@mail.gmail.com>
 <0357f124-8017-1563-6dbf-04ed10d7c041@2ndQuadrant.com>
 <CABUevEyVyx119X0jp11GccRYPJ1XyHR5DmC9ZnJ_jK7zV=JiXw@mail.gmail.com>
From: David Steele <david@pgmasters.net>
Message-ID: <eba6478f-e171-4dba-ed5d-3644511d941d@pgmasters.net>
Date: Wed, 17 Jun 2020 12:27:03 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: 
 <CABUevEyVyx119X0jp11GccRYPJ1XyHR5DmC9ZnJ_jK7zV=JiXw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/17/20 12:08 PM, Magnus Hagander wrote:
> On Wed, Jun 17, 2020 at 4:15 PM Andrew Dunstan 
> <andrew.dunstan@2ndquadrant.com <mailto:andrew.dunstan@2ndquadrant.com>> 
> 
>     I'm not sure I like doing s/Black/Block/ here. It reads oddly. There are
>     too many other uses of Block in the sources. Forbidden might be a better
>     substitution, or Banned maybe. BanList is even less characters than
>     BlackList.
> 
> I'd be OK with either of those really -- I went with block because it 
> was the easiest one :)
> 
> Not sure the number of characters is the important part :) Banlist does 
> make sense to me for other reasons though -- it's what it is, isn't it? 
> It bans those oids from being used in the current session -- I don't 
> think there's any struggle to "make that sentence work", which means 
> that seems like the relevant term.

I've seen also seen allowList/denyList as an alternative. I do agree 
that blockList is a bit confusing since we often use block in a very 
different context.

> I do think it's worth doing -- it's a small round of changes, and it 
> doesn't change anything user-exposed, so the cost for us is basically zero.

+1

Regards,
-- 
-David
david@pgmasters.net