From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: Windows warnings from VS 2017
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <f6488a36-4702-6d50-9fb4-fee10bb49497@2ndQuadrant.com>
 <CAB7nPqSS+FZkQ2s3d7O2Z-Ae3kcGcNq-XqTMm7Q19dR9TYng-A@mail.gmail.com>
 <7cabcef8-c2eb-f7d1-e4a2-63b93115b75c@2ndQuadrant.com>
 <7800.1505950322@sss.pgh.pa.us>
Message-ID: <ec06d7f5-2097-a526-e146-a22545487a2e@2ndQuadrant.com>
Date: Wed, 20 Sep 2017 20:16:28 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <7800.1505950322@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 09/20/2017 07:32 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 09/20/2017 06:13 PM, Michael Paquier wrote:
>>> Those are around for some time, see here:
>>> https://www.postgresql.org/message-id/CAB7nPqTkW=b_1JVvYWd_G0WrKOT+4uFQjGGrv8osQbUZzXGXdA@mail.gmail.com
>>> But there has been no actual agreement about how to fix them..
>> Oh. Missed that.
>> My solution was going to be slightly different. I was going to enclose
>> the #ifdef'd code in a bare block and move the rte declaration inside
>> that block.
> Of the various solutions proposed in the previous thread, I think the
> most salable alternative is probably ilmari's: get rid of the variable
> and write the assert like
>
>    Assert(planner_rt_fetch(rel->relid, root)->rtekind == RTE_SUBQUERY);
>
> That's a pretty minimal change and it doesn't add any cycles to the
> non-Assert case.
>
> 	


I can live with that. Will do.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers