Subject: Re: pg_stat_statements and "IN" conditions
To: Zhihong Yu <zyu@yugabyte.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>, Greg Stark <stark@mit.edu>,
 Pavel Trukhanov <pavel.trukhanov@gmail.com>
References: 
 <CA+q6zcWtUbT_Sxj0V6HY6EZ89uv5wuG5aefpe_9n0Jr3VwntFg@mail.gmail.com>
 <20201118160432.hyko73sqc2bf7nkj@localhost>
 <20201226104635.uvzkftzu72zg5qux@localhost>
 <CALNJ-vQx7u-Nq_wVun72CVrHe4DcGfEurj_ikckJrRy2Pem=JA@mail.gmail.com>
 <20210105125230.etgmgixnn6fmpszl@localhost>
 <CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>
From: David Steele <david@pgmasters.net>
Message-ID: <ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net>
Date: Thu, 18 Mar 2021 09:38:09 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: 
 <CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ec47aa60-0a7b-ea3a-222a-5c6a754c2def%40pgmasters.net>
Precedence: bulk

On 1/5/21 10:51 AM, Zhihong Yu wrote:
> 
> +   int         lastExprLenght = 0;
> 
> Did you mean to name the variable lastExprLenghth ?
> 
> w.r.t. extracting to helper method, the second and third 
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.

Dmitry, thoughts on this review?

Regards,
-- 
-David
david@pgmasters.net