Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1repta-00Dm9H-PF for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Feb 2024 05:20:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1reptZ-000xeY-8C for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Feb 2024 05:20:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reptY-000xeQ-QV for pgsql-hackers@lists.postgresql.org; Tue, 27 Feb 2024 05:20:49 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1reptV-001MdR-Jv for pgsql-hackers@lists.postgresql.org; Tue, 27 Feb 2024 05:20:48 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-787ba57afd1so253004485a.0 for ; Mon, 26 Feb 2024 21:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1709011244; x=1709616044; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fwCTfS4lmWgQvEVsBu8i5xLNshveccftRDlqFmYGnq0=; b=bBN5flSPezn4PbFp1IEKXri7thYALSAGt/SA3yK6hgRAPZ/bYcTwhyEl6koTei3Bru U4WcKlb8ky764LCpWnV9a6Wl4hMmoJifw/c/9pSZulq2uzspNTD7HNokWTmT6fHhMavp flTI1Ss7of9rUCfp0k4i15uu7br3dM/E6U4PCry7nNteT4DaMAf78o1IpV9scYlIANNU SVu89gZ9X0vGmt8R/r0cbsNQv5/rEqYMEPwvWSADtPdbWvfxY7wIxqKp7Tehh9Bmggio KcKhSN83lUJw2VIne5u/gEM/crwPSI2+EnFHDiRB3Z707kQf1FkXBrVys5CUR5fRmyUd ybSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709011244; x=1709616044; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fwCTfS4lmWgQvEVsBu8i5xLNshveccftRDlqFmYGnq0=; b=LrwXKfcsUmBjadmeon/pGa/7QrNWydaR0O0mHdPN/Q5TLnxF1xLG0s2mmsIpriEWU4 C5vkFsUsWNrHrWo8jlhhBcV+HFr9bD6PH5mUs8nqvnEM+F5VHJ1nik9PG6PQIEn263Tm IbvYbTMbuUoVp+WNXZso03NB6vc0fugXTzaWMRsiCU5C3nUimx0FzlVTgVccdGa0DMtx f8KinMjSgAek8mit06xvngzoYsopgpH9CmM6U/O11DcC0rQ8QeLdLoK2Vm+l3JCL77JL k7vdSizQI+aWcJLTsKTYFoD3Ykd4RlZck2Vn4Ru4o9pAMtU0fEEfA7Rw23h7JY8MNnjW xFdA== X-Forwarded-Encrypted: i=1; AJvYcCWxi5XYv7VXU0MdNrvCcuD1DZvfjTHadCm/6av78fJ9IR7s1P4zAnDP6HUip8DKTid/9rC5mZhLUIyqaDkrD9IWL0X3yiGQxjkPf1tQSRKOthpq X-Gm-Message-State: AOJu0YxoXwd0hiRJTDheRQJcVPgw6mM3tmjRRxCwyQ0zojhLOQQ4iULL 7rCTzR8Cj+dZ1Bs+jRUK6Ef5tacrBG10U5zgDVvNQCIcNvhYAiptZ6IQSVaJwy4= X-Google-Smtp-Source: AGHT+IGaxB5DSMgMH40h8xP9cdzi1jMvb59ISpuQwe2DGln5ne/d106xNqzIwSkJjGEsQkKm3CXXXg== X-Received: by 2002:ae9:f813:0:b0:786:6e8:5a86 with SMTP id x19-20020ae9f813000000b0078606e85a86mr1169765qkh.63.1709011243736; Mon, 26 Feb 2024 21:20:43 -0800 (PST) Received: from ?IPV6:2605:a601:91f3:1900::2bb? ([2605:a601:91f3:1900::2bb]) by smtp.googlemail.com with ESMTPSA id h17-20020a05620a245100b00787930320b6sm3254749qkn.70.2024.02.26.21.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 21:20:43 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 00:20:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: WIP Incremental JSON Parser Content-Language: en-US From: Andrew Dunstan To: Jacob Champion Cc: Robert Haas , Peter Smith , PostgreSQL Hackers References: <7b0a51d6-0d9d-7366-3a1a-f74397a02f55@dunslane.net> <8dabdf4d-a365-5b9f-db38-908ace60c526@dunslane.net> <99332c8b-0bea-1ef4-efa6-406635eb34b7@dunslane.net> <8cc158a4-5d51-737c-16a1-8885d04e4cab@dunslane.net> <3892d996-0ec8-3a56-1a6c-b397a3c31516@dunslane.net> <3efe8333-3285-1d9d-5ad3-0f9784d5c1c4@dunslane.net> <1778cdac-bb93-5bbd-1505-5684e95b0094@dunslane.net> <1b30469a-9d29-c021-f28a-74e248760aa4@dunslane.net> In-Reply-To: <1b30469a-9d29-c021-f28a-74e248760aa4@dunslane.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-02-26 Mo 19:20, Andrew Dunstan wrote: > > On 2024-02-26 Mo 10:10, Jacob Champion wrote: >> On Mon, Feb 26, 2024 at 7:08 AM Jacob Champion >> wrote: >>> As a brute force example of the latter, with the attached diff I get >>> test failures at chunk sizes 1, 2, 3, 4, 6, and 12. >> But this time with the diff. >> > > Ouch. I'll check it out. Thanks! > > > The good news is that the parser is doing fine - this issue was due to a thinko on my part in the test program that got triggered by the input file size being an exact multiple of the chunk size. I'll have a new patch set later this week. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com