Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPNh6-0001O8-Nb for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 09:21:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPNh5-0004fP-Fe for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 09:21:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPNh5-0004fI-3J for pgsql-hackers@lists.postgresql.org; Tue, 29 Oct 2019 09:21:39 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iPNh1-0003ed-Ae for pgsql-hackers@postgresql.org; Tue, 29 Oct 2019 09:21:37 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9041820EAA for ; Tue, 29 Oct 2019 05:21:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 29 Oct 2019 05:21:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=3IdFwTWbqaQ9bhyqRMk20/eai74Uf YLM0SjMbmsZV18=; b=TWzv/jwKGORE8evk46/RJzsCO81QDsR050pQAu1MmmzUG r87mnDJL/7E17VHQI2nsD5MgQC0GvCF/UsbCZ5uMEATSW+oU1QBOXw/en7HKsMx8 jp8pR75TbPdGQIaFDIEO4tL452jljcXF2URtEDl7AHmOYytdD0IQldDa6XRuWGID lCz9b/6+5wggJGXZhdyCVlAaR83arIXuKHOpm0R7AUEQd8KuYNQVTruMzA6xJlAZ n35oR7LTq/zqNh+Um264rPRBAtKnakqrMBC81eKXYkeMYXOYAauLayOPjU8kwtrW HZ+ZBbSKUiXlzqAirtux+7Engs0qm8zrjMCFr8mbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtudcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepvffhufhokffffgggtgesmhdtreertdefje enucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgv nhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhmqeenucffohhmrghinhepvdhnug hquhgrughrrghnthdrtghomhenucfkphepleefrddvgedvrddugeejrdejleenucfrrghr rghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqhhurg gurhgrnhhtrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from april.pezone.net (p5df2934f.dip0.t-ipconnect.de [93.242.147.79]) by mail.messagingengine.com (Postfix) with ESMTPA id B95EAD60067 for ; Tue, 29 Oct 2019 05:21:33 -0400 (EDT) To: pgsql-hackers From: Peter Eisentraut Subject: Remove unused function argument Organization: 2ndQuadrant Message-ID: Date: Tue, 29 Oct 2019 10:21:32 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9EF8D64C2A8163550A35B81E" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------9EF8D64C2A8163550A35B81E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The cache_plan argument to ri_PlanCheck has not been used since e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. That commit said "I left it alone in case there is any future need for it" but there hasn't been a need in 7 years, and I find it confusing to have an unused function argument without a clear purpose. It would trivial to put it back if needed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------9EF8D64C2A8163550A35B81E Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Remove-unused-function-argument.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Remove-unused-function-argument.patch" RnJvbSA5NDJhMmE5ZmQxOWZkZWI3OWU4MmI5ODQ5YTU1ZGFmN2ZhNWI5YmZmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVHVlLCAyOSBPY3QgMjAxOSAxMDoxMzoxNCArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIFJlbW92ZSB1bnVzZWQgZnVuY3Rpb24gYXJndW1lbnQKClRoZSBjYWNoZV9w bGFuIGFyZ3VtZW50IHRvIHJpX1BsYW5DaGVjayBoYXMgbm90IGJlZW4gdXNlZCBzaW5jZQpl OGM5ZmQ1ZmRmNzY4MzIzOTExZjcwODhlODI4N2Y2M2I1MTNjM2M2LgotLS0KIHNyYy9iYWNr ZW5kL3V0aWxzL2FkdC9yaV90cmlnZ2Vycy5jIHwgMjcgKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3JpX3RyaWdnZXJzLmMg Yi9zcmMvYmFja2VuZC91dGlscy9hZHQvcmlfdHJpZ2dlcnMuYwppbmRleCBkZTBmODEwMDYy Li5lZjk0NmQ1ZWY1IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcmlfdHJp Z2dlcnMuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9hZHQvcmlfdHJpZ2dlcnMuYwpAQCAt MjEwLDggKzIxMCw3IEBAIHN0YXRpYyBjb25zdCBSSV9Db25zdHJhaW50SW5mbyAqcmlfRmV0 Y2hDb25zdHJhaW50SW5mbyhUcmlnZ2VyICp0cmlnZ2VyLAogCQkJCQkJCQkJCQkJCSAgIFJl bGF0aW9uIHRyaWdfcmVsLCBib29sIHJlbF9pc19wayk7CiBzdGF0aWMgY29uc3QgUklfQ29u c3RyYWludEluZm8gKnJpX0xvYWRDb25zdHJhaW50SW5mbyhPaWQgY29uc3RyYWludE9pZCk7 CiBzdGF0aWMgU1BJUGxhblB0ciByaV9QbGFuQ2hlY2soY29uc3QgY2hhciAqcXVlcnlzdHIs IGludCBuYXJncywgT2lkICphcmd0eXBlcywKLQkJCQkJCQkgICBSSV9RdWVyeUtleSAqcWtl eSwgUmVsYXRpb24gZmtfcmVsLCBSZWxhdGlvbiBwa19yZWwsCi0JCQkJCQkJICAgYm9vbCBj YWNoZV9wbGFuKTsKKwkJCQkJCQkgICBSSV9RdWVyeUtleSAqcWtleSwgUmVsYXRpb24gZmtf cmVsLCBSZWxhdGlvbiBwa19yZWwpOwogc3RhdGljIGJvb2wgcmlfUGVyZm9ybUNoZWNrKGNv bnN0IFJJX0NvbnN0cmFpbnRJbmZvICpyaWluZm8sCiAJCQkJCQkJUklfUXVlcnlLZXkgKnFr ZXksIFNQSVBsYW5QdHIgcXBsYW4sCiAJCQkJCQkJUmVsYXRpb24gZmtfcmVsLCBSZWxhdGlv biBwa19yZWwsCkBAIC00MjIsNyArNDIxLDcgQEAgUklfRktleV9jaGVjayhUcmlnZ2VyRGF0 YSAqdHJpZ2RhdGEpCiAKIAkJLyogUHJlcGFyZSBhbmQgc2F2ZSB0aGUgcGxhbiAqLwogCQlx cGxhbiA9IHJpX1BsYW5DaGVjayhxdWVyeWJ1Zi5kYXRhLCByaWluZm8tPm5rZXlzLCBxdWVy eW9pZHMsCi0JCQkJCQkJICZxa2V5LCBma19yZWwsIHBrX3JlbCwgdHJ1ZSk7CisJCQkJCQkJ ICZxa2V5LCBma19yZWwsIHBrX3JlbCk7CiAJfQogCiAJLyoKQEAgLTU0OSw3ICs1NDgsNyBA QCByaV9DaGVja19Qa19NYXRjaChSZWxhdGlvbiBwa19yZWwsIFJlbGF0aW9uIGZrX3JlbCwK IAogCQkvKiBQcmVwYXJlIGFuZCBzYXZlIHRoZSBwbGFuICovCiAJCXFwbGFuID0gcmlfUGxh bkNoZWNrKHF1ZXJ5YnVmLmRhdGEsIHJpaW5mby0+bmtleXMsIHF1ZXJ5b2lkcywKLQkJCQkJ CQkgJnFrZXksIGZrX3JlbCwgcGtfcmVsLCB0cnVlKTsKKwkJCQkJCQkgJnFrZXksIGZrX3Jl bCwgcGtfcmVsKTsKIAl9CiAKIAkvKgpAQCAtNzQxLDcgKzc0MCw3IEBAIHJpX3Jlc3RyaWN0 KFRyaWdnZXJEYXRhICp0cmlnZGF0YSwgYm9vbCBpc19ub19hY3Rpb24pCiAKIAkJLyogUHJl cGFyZSBhbmQgc2F2ZSB0aGUgcGxhbiAqLwogCQlxcGxhbiA9IHJpX1BsYW5DaGVjayhxdWVy eWJ1Zi5kYXRhLCByaWluZm8tPm5rZXlzLCBxdWVyeW9pZHMsCi0JCQkJCQkJICZxa2V5LCBm a19yZWwsIHBrX3JlbCwgdHJ1ZSk7CisJCQkJCQkJICZxa2V5LCBma19yZWwsIHBrX3JlbCk7 CiAJfQogCiAJLyoKQEAgLTg0Niw3ICs4NDUsNyBAQCBSSV9GS2V5X2Nhc2NhZGVfZGVsKFBH X0ZVTkNUSU9OX0FSR1MpCiAKIAkJLyogUHJlcGFyZSBhbmQgc2F2ZSB0aGUgcGxhbiAqLwog CQlxcGxhbiA9IHJpX1BsYW5DaGVjayhxdWVyeWJ1Zi5kYXRhLCByaWluZm8tPm5rZXlzLCBx dWVyeW9pZHMsCi0JCQkJCQkJICZxa2V5LCBma19yZWwsIHBrX3JlbCwgdHJ1ZSk7CisJCQkJ CQkJICZxa2V5LCBma19yZWwsIHBrX3JlbCk7CiAJfQogCiAJLyoKQEAgLTk2OCw3ICs5Njcs NyBAQCBSSV9GS2V5X2Nhc2NhZGVfdXBkKFBHX0ZVTkNUSU9OX0FSR1MpCiAKIAkJLyogUHJl cGFyZSBhbmQgc2F2ZSB0aGUgcGxhbiAqLwogCQlxcGxhbiA9IHJpX1BsYW5DaGVjayhxdWVy eWJ1Zi5kYXRhLCByaWluZm8tPm5rZXlzICogMiwgcXVlcnlvaWRzLAotCQkJCQkJCSAmcWtl eSwgZmtfcmVsLCBwa19yZWwsIHRydWUpOworCQkJCQkJCSAmcWtleSwgZmtfcmVsLCBwa19y ZWwpOwogCX0KIAogCS8qCkBAIC0xMTQ3LDcgKzExNDYsNyBAQCByaV9zZXQoVHJpZ2dlckRh dGEgKnRyaWdkYXRhLCBib29sIGlzX3NldF9udWxsKQogCiAJCS8qIFByZXBhcmUgYW5kIHNh dmUgdGhlIHBsYW4gKi8KIAkJcXBsYW4gPSByaV9QbGFuQ2hlY2socXVlcnlidWYuZGF0YSwg cmlpbmZvLT5ua2V5cywgcXVlcnlvaWRzLAotCQkJCQkJCSAmcWtleSwgZmtfcmVsLCBwa19y ZWwsIHRydWUpOworCQkJCQkJCSAmcWtleSwgZmtfcmVsLCBwa19yZWwpOwogCX0KIAogCS8q CkBAIC0yMTY1LDggKzIxNjQsNyBAQCBJbnZhbGlkYXRlQ29uc3RyYWludENhY2hlQ2FsbEJh Y2soRGF0dW0gYXJnLCBpbnQgY2FjaGVpZCwgdWludDMyIGhhc2h2YWx1ZSkKICAqLwogc3Rh dGljIFNQSVBsYW5QdHIKIHJpX1BsYW5DaGVjayhjb25zdCBjaGFyICpxdWVyeXN0ciwgaW50 IG5hcmdzLCBPaWQgKmFyZ3R5cGVzLAotCQkJIFJJX1F1ZXJ5S2V5ICpxa2V5LCBSZWxhdGlv biBma19yZWwsIFJlbGF0aW9uIHBrX3JlbCwKLQkJCSBib29sIGNhY2hlX3BsYW4pCisJCQkg UklfUXVlcnlLZXkgKnFrZXksIFJlbGF0aW9uIGZrX3JlbCwgUmVsYXRpb24gcGtfcmVsKQog ewogCVNQSVBsYW5QdHIJcXBsYW47CiAJUmVsYXRpb24JcXVlcnlfcmVsOwpAQCAtMjE5Nywx MiArMjE5NSw5IEBAIHJpX1BsYW5DaGVjayhjb25zdCBjaGFyICpxdWVyeXN0ciwgaW50IG5h cmdzLCBPaWQgKmFyZ3R5cGVzLAogCS8qIFJlc3RvcmUgVUlEIGFuZCBzZWN1cml0eSBjb250 ZXh0ICovCiAJU2V0VXNlcklkQW5kU2VjQ29udGV4dChzYXZlX3VzZXJpZCwgc2F2ZV9zZWNf Y29udGV4dCk7CiAKLQkvKiBTYXZlIHRoZSBwbGFuIGlmIHJlcXVlc3RlZCAqLwotCWlmIChj YWNoZV9wbGFuKQotCXsKLQkJU1BJX2tlZXBwbGFuKHFwbGFuKTsKLQkJcmlfSGFzaFByZXBh cmVkUGxhbihxa2V5LCBxcGxhbik7Ci0JfQorCS8qIFNhdmUgdGhlIHBsYW4gKi8KKwlTUElf a2VlcHBsYW4ocXBsYW4pOworCXJpX0hhc2hQcmVwYXJlZFBsYW4ocWtleSwgcXBsYW4pOwog CiAJcmV0dXJuIHFwbGFuOwogfQotLSAKMi4yMy4wCgo= --------------9EF8D64C2A8163550A35B81E--