pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFix repetition in hash index documentation
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2025-12-09 52382feb78 a59b03995a ca98d8ba10 08e1ea3b28 52a95886f7 Doc: fix typo in hash index documentation
* Fix repetition in hash index documentation
@ 2025-12-08 19:40 David Geier <geidav.pg@gmail.com>
2025-12-09 01:21 ` Re: Fix repetition in hash index documentation David Rowley <dgrowleyml@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: David Geier @ 2025-12-08 19:40 UTC (permalink / raw)
To: pgsql-hackers
Hi hackers!
Attached patch fixes a repetition in the user-facing hash index
documentation and the README.
--
David Geier
Attachments:
0001-Fix-hash-index-documentation.patch (text/x-patch, 1.9K) download
From 6420ef7f24f150c88110343634758ae8fb3a779d Mon Sep 17 00:00:00 2001
From: David Geier <geidav.pg@gmail.com>
Date: Mon, 8 Dec 2025 20:37:02 +0100
Subject: [PATCH] Fix hash index documentation
---
doc/src/sgml/hash.sgml | 2 +-
src/backend/access/hash/README | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/hash.sgml b/doc/src/sgml/hash.sgml
index 9e69ef91fe8..5bb280af71d 100644
--- a/doc/src/sgml/hash.sgml
+++ b/doc/src/sgml/hash.sgml
@@ -125,7 +125,7 @@
Both scanning the index and inserting tuples require locating the bucket
where a given tuple ought to be located. To do this, we need the bucket
count, highmask, and lowmask from the metapage; however, it's undesirable
- for performance reasons to have to have to lock and pin the metapage for
+ for performance reasons to have to lock and pin the metapage for
every such operation. Instead, we retain a cached copy of the metapage
in each backend's relcache entry. This will produce the correct bucket
mapping as long as the target bucket hasn't been split since the last
diff --git a/src/backend/access/hash/README b/src/backend/access/hash/README
index 13dc59c124a..8187d20452f 100644
--- a/src/backend/access/hash/README
+++ b/src/backend/access/hash/README
@@ -171,7 +171,7 @@ Metapage Caching
Both scanning the index and inserting tuples require locating the bucket
where a given tuple ought to be located. To do this, we need the bucket
count, highmask, and lowmask from the metapage; however, it's undesirable
-for performance reasons to have to have to lock and pin the metapage for
+for performance reasons to have to lock and pin the metapage for
every such operation. Instead, we retain a cached copy of the metapage
in each backend's relcache entry. This will produce the correct
bucket mapping as long as the target bucket hasn't been split since the
--
2.51.0
* Re: Fix repetition in hash index documentation
2025-12-08 19:40 Fix repetition in hash index documentation David Geier <geidav.pg@gmail.com>
@ 2025-12-09 01:21 ` David Rowley <dgrowleyml@gmail.com>
2025-12-09 13:38 ` Re: Fix repetition in hash index documentation David Geier <geidav.pg@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: David Rowley @ 2025-12-09 01:21 UTC (permalink / raw)
To: David Geier <geidav.pg@gmail.com>; +Cc: pgsql-hackers
On Tue, 9 Dec 2025 at 08:41, David Geier <geidav.pg@gmail.com> wrote:
> Attached patch fixes a repetition in the user-facing hash index
> documentation and the README.
Thanks. I can take care of that. I'll backpatch to v15 due to the sgml
docs. The README issue exists in v14, but likely isn't doing enough
harm to warrant fixing it given that version only has 11 months of
life left.
David
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Fix repetition in hash index documentation
2025-12-08 19:40 Fix repetition in hash index documentation David Geier <geidav.pg@gmail.com>
2025-12-09 01:21 ` Re: Fix repetition in hash index documentation David Rowley <dgrowleyml@gmail.com>
@ 2025-12-09 13:38 ` David Geier <geidav.pg@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: David Geier @ 2025-12-09 13:38 UTC (permalink / raw)
To: David Rowley <dgrowleyml@gmail.com>; +Cc: pgsql-hackers
On 09.12.2025 02:21, David Rowley wrote:
> On Tue, 9 Dec 2025 at 08:41, David Geier <geidav.pg@gmail.com> wrote:
>> Attached patch fixes a repetition in the user-facing hash index
>> documentation and the README.
>
> Thanks. I can take care of that. I'll backpatch to v15 due to the sgml
> docs. The README issue exists in v14, but likely isn't doing enough
> harm to warrant fixing it given that version only has 11 months of
> life left.
Thanks!
--
David Geier
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-12-09 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-12-08 19:40 Fix repetition in hash index documentation David Geier <geidav.pg@gmail.com>
2025-12-09 01:21 ` David Rowley <dgrowleyml@gmail.com>
2025-12-09 13:38 ` David Geier <geidav.pg@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox