Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hoWH6-0005LE-0O for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jul 2019 17:02:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hoWH4-0000zH-Qq for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jul 2019 17:02:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hoWH4-0000zA-Hz for pgsql-hackers@lists.postgresql.org; Fri, 19 Jul 2019 17:02:26 +0000 Received: from mail-qt1-f172.google.com ([209.85.160.172]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hoWH2-0004eN-F5 for pgsql-hackers@postgresql.org; Fri, 19 Jul 2019 17:02:26 +0000 Received: by mail-qt1-f172.google.com with SMTP id l9so31695141qtu.6 for ; Fri, 19 Jul 2019 10:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=sKf8bDqZxxXXPM3ZXWvR7bBvVIqQTOFFSr6VgLHAWQ4=; b=IoHZEAo8Fx9vpuSd9ZMGkYBW03Pmt7/Tna8jTCTlrvPvMtbhhURXT306jdVyCg3x0E MWxijFJXnoPYuvpAap7/nzEYbqNoPFsECpWqZn5/K+t2Ndmfl74ZbK3bAf9vKoX8ZTtZ C55w7Ejlj+RfnHZt7w4MUd03fldjNq1RIzDuHd4yucZqD5Q5aoJOi7fHPKzJ0YuYjFiM Q1uJo9MZxsJhQmgLhClwflQx8gsJo2AFKPXasM0ROFAYuC2Kc9kPNIzC3HBLZcAfjTcZ tEMIRAaF+uexMFIm0sHQ4WEV/hln4f+d+DDQfrBaISEsbvWzJ15y4Q3j1Vrq626pOa1u QF0g== X-Gm-Message-State: APjAAAVectZB8S5ZYuj0F3WYbEbRtm4wyMdwaqNk1XAkmvVj3gnIR4WA kuek2GNDf9bNoLfecyFr+/3bGfevnC5TNA== X-Google-Smtp-Source: APXvYqwQivoLmbcXnU9Tlxf/FjF+hB0WAGYLjyosspAGiSwvKTZChVwdfVNbVlYMF3mQjg4hrHGilA== X-Received: by 2002:ac8:53d3:: with SMTP id c19mr38726757qtq.225.1563555742633; Fri, 19 Jul 2019 10:02:22 -0700 (PDT) Received: from localhost.localdomain (c-24-61-8-151.hsd1.ma.comcast.net. [24.61.8.151]) by smtp.gmail.com with ESMTPSA id c45sm16356506qte.70.2019.07.19.10.02.21 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 10:02:22 -0700 (PDT) Reply-To: jesper.pedersen@redhat.com Subject: Re: pg_receivewal documentation To: Michael Paquier Cc: Laurenz Albe , Alvaro Herrera , PostgreSQL-development References: <20190716050555.GA1439@paquier.xyz> <65c3ecdf-8995-34cb-83c4-50068877e632@redhat.com> <20190717013835.GA2130@paquier.xyz> <44e51f9f60abb872854879c91da0ed3b67a6ba95.camel@cybertec.at> <20190717080424.GB20614@paquier.xyz> <7eaf748c-3f40-c994-0eb3-7d87709588d0@redhat.com> <184780f1f90a31c4c8b53f0e6328bf5aaae4f786.camel@cybertec.at> <20190718052909.GF1416@paquier.xyz> <20190719012757.GD1859@paquier.xyz> From: Jesper Pedersen Organization: Red Hat Message-ID: Date: Fri, 19 Jul 2019 13:02:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190719012757.GD1859@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, On 7/18/19 9:27 PM, Michael Paquier wrote: > The location of the warning is > also harder to catch for the reader, so instead let's move it to the > top where we have an extra description for --synchronous. I am > finishing with the attached that I would be fine to commit and > back-patch as needed. Does that sound fine? LGTM. Best regards, Jesper