Message-ID: <ed82a883-d751-4e61-977b-a7a1150dbf32@proxel.se>
Date: Wed, 12 Mar 2025 11:03:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: dblink query interruptibility
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
References: <20231122012945.74@rfd.leadboat.com>
 <bb9f565d-4ca5-4e30-9008-fa538c6895ef@proxel.se>
 <20250311234839.9c.nmisch@google.com>
Content-Language: en-US
From: Andreas Karlsson <andreas@proxel.se>
In-Reply-To: <20250311234839.9c.nmisch@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ed82a883-d751-4e61-977b-a7a1150dbf32%40proxel.se>
Precedence: bulk

On 3/12/25 12:48 AM, Noah Misch wrote:
> The CREATE DATABASE hang is indeed new in v15.  The general dblink missed
> interrupt processing (e.g. pg_cancel_backend response delay) is an old bug.

Aha, that was what you were referring to! My apologies, was reading your 
mail a bit too quickly. :)

> Commit d3c5f37 used the new functions for postgres_fdw, not just dblink.  That
> caused message changes detailed in
> postgr.es/m/CAHGQGwGpDTXeg8K1oTmDv9nankaKTrCD-XW-tnkzo6%3DE9p5%3Duw%40mail.gmail.com
> so I'm inclined to omit postgres_fdw changes in back branches.  postgres_fdw
> was already interruptible, so the point of making postgres_fdw adopt the
> functions was to reduce code duplication.

Makes sense.

> Overall, in the absence of objections, I will queue a task to back-patch the
> non-postgres_fdw portion of commit d3c5f37 to v13-v16.

Thanks!

Andreas