Message-ID: <edcd87ec-e91d-44f8-a8a3-d19c786b2712@uni-muenster.de>
Date: Fri, 8 May 2026 14:22:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix wrong error message from pg_get_tablespace_ddl()
To: Andrew Dunstan <andrew@dunslane.net>, Chao Li <li.evan.chao@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <53D05145-CE87-424F-A492-BB22A09BBE11@gmail.com>
 <9cc5e7a5-1cbc-4e07-ace4-ad04a8e1a6fe@uni-muenster.de>
 <91b25e9b-5761-4046-84ef-cb73b5db17e6@dunslane.net>
Content-Language: en-US, de-DE
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <91b25e9b-5761-4046-84ef-cb73b5db17e6@dunslane.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/edcd87ec-e91d-44f8-a8a3-d19c786b2712%40uni-muenster.de>
Precedence: bulk

On 08/05/2026 14:07, Andrew Dunstan wrote:
> I'm not 100% convinced these are in fact wrong. The user asks for the 
> DDL for a named role or tablespace and we tell them that they don't have 
> the privilege to get the information for that object. If we tell them 
> that the problem is that they don't have privilege on the underlying 
> catalog table, they might think "Well, I didn't ask for that".

I honestly don't have a strong opinion either way.

It depends on what we expect from the error message. If its purpose is 
simply to tell the user "you can't access this object," the current 
message is totally fine. If, however, the goal is to show the error's 
root cause, it could be a bit misleading.

Best, Jim