Content-Type: multipart/alternative;
 boundary="------------e8fAb8MQz13waLCeEt0aF1yY"
Message-ID: <eddf240a-05b2-4f6b-9a6e-81b0a9523353@dunslane.net>
Date: Wed, 3 Dec 2025 10:35:53 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgindent versus struct members and typedefs
To: Chao Li <li.evan.chao@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Rahila Syed <rahilasyed90@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us>
 <5E70CB69-1E2D-471B-8CF8-83205E5E14CE@gmail.com>
 <512380.1764717196@sss.pgh.pa.us>
 <B55A39FB-97F4-4869-A2A3-59429486ED5F@gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <B55A39FB-97F4-4869-A2A3-59429486ED5F@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/eddf240a-05b2-4f6b-9a6e-81b0a9523353%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------e8fAb8MQz13waLCeEt0aF1yY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2025-12-02 Tu 6:31 PM, Chao Li wrote:
>
>> On Dec 3, 2025, at 07:13, Tom Lane<tgl@sss.pgh.pa.us> wrote:
>>
>> Chao Li<li.evan.chao@gmail.com> writes:
>>>> On Dec 3, 2025, at 06:51, Tom Lane<tgl@sss.pgh.pa.us> wrote:
>>>> In this case, I think pgindent is indirectly enforcing good style.
>>>> I do not like omitting braces around anything that's more than one
>>>> line; readers have to pay close attention to whether the code is
>>>> doing what it was intended to.
>>> For “one line”, do you mean only a single line of statement or one line statement plus one line comment?
>> In my head, a comment and a statement are two lines, and so need
>> wrapping braces as much as two statements would do.  I realize that
>> C compilers think differently, but for readability and modifiability
>> reasons that's the approach I take.
>>
> Totally agreed. In my first job at Lucent Technologies, the coding standard was that braces should always be added even if a clause has only one line of code. I remember one of the explanations was like, if braces has been added, then later when a new line of code is added to the clause, there is only one line of diff, otherwise braces need to be added, so it would be 3 lines of diffs.
>

+1. One of the things I find particularly un-aesthetic is having some 
branches of an if statement with braces and some without. We have lots 
of cases of that, but I try to avoid it.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------e8fAb8MQz13waLCeEt0aF1yY
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2025-12-02 Tu 6:31 PM, Chao Li
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:B55A39FB-97F4-4869-A2A3-59429486ED5F@gmail.com">
      <pre wrap="" class="moz-quote-pre">

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">On Dec 3, 2025, at 07:13, Tom Lane <a class="moz-txt-link-rfc2396E" href="mailto:tgl@sss.pgh.pa.us">&lt;tgl@sss.pgh.pa.us&gt;</a> wrote:

Chao Li <a class="moz-txt-link-rfc2396E" href="mailto:li.evan.chao@gmail.com">&lt;li.evan.chao@gmail.com&gt;</a> writes:
</pre>
        <blockquote type="cite">
          <blockquote type="cite">
            <pre wrap="" class="moz-quote-pre">On Dec 3, 2025, at 06:51, Tom Lane <a class="moz-txt-link-rfc2396E" href="mailto:tgl@sss.pgh.pa.us">&lt;tgl@sss.pgh.pa.us&gt;</a> wrote:
In this case, I think pgindent is indirectly enforcing good style.
I do not like omitting braces around anything that's more than one
line; readers have to pay close attention to whether the code is
doing what it was intended to.
</pre>
          </blockquote>
        </blockquote>
        <pre wrap="" class="moz-quote-pre">
</pre>
        <blockquote type="cite">
          <pre wrap="" class="moz-quote-pre">For “one line”, do you mean only a single line of statement or one line statement plus one line comment?
</pre>
        </blockquote>
        <pre wrap="" class="moz-quote-pre">
In my head, a comment and a statement are two lines, and so need
wrapping braces as much as two statements would do.  I realize that
C compilers think differently, but for readability and modifiability
reasons that's the approach I take.

</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Totally agreed. In my first job at Lucent Technologies, the coding standard was that braces should always be added even if a clause has only one line of code. I remember one of the explanations was like, if braces has been added, then later when a new line of code is added to the clause, there is only one line of diff, otherwise braces need to be added, so it would be 3 lines of diffs.

</pre>
    </blockquote>
    <p><br>
    </p>
    <p>+1. One of the things I find particularly un-aesthetic is having
      some branches of an if statement with braces and some without. We
      have lots of cases of that, but I try to avoid it.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------e8fAb8MQz13waLCeEt0aF1yY--