Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x9aJ6-0000000271h-0K8E
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 24 Sep 2026 03:39:36 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.98.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x9aJ4-000000098qo-0ehM
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 24 Sep 2026 03:39:34 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <ju.grigorev@ftdata.ru>)
	id 1x9aJ3-000000098qf-3gag
	for pgsql-hackers@lists.postgresql.org;
	Thu, 24 Sep 2026 03:39:33 +0000
Received: from email.dnscdc.tech ([194.226.250.15])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <ju.grigorev@ftdata.ru>)
	id 1x9aJ0-00000000xlC-031v
	for pgsql-hackers@lists.postgresql.org;
	Thu, 24 Sep 2026 03:39:33 +0000
Received: with id D561628077A;
	Thu, 24 Sep 2026 10:39:25 +0700 (+07)
Received: with id 2FE8928002F;
	Thu, 24 Sep 2026 10:39:22 +0700 (+07)
From: Grigorev Jurij <ju.grigorev@ftdata.ru>
To: Michael Paquier <michael@paquier.xyz>
CC: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized
 pgstats hash entry
Thread-Topic: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized
 pgstats hash entry
Thread-Index: 
 AQHdP268ccO9PMgx5Ei0J2uuaTqIjLbE5gWAgAEact2AC6lZAIAAD7eAgACbjC3//537gIAAg+33gAoCfQCAALNneA==
Date: Thu, 24 Sep 2026 03:39:10 +0000
Message-ID: <ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain>
References: <ddc3ecfb01ce4e9698b23cc59767f016@localhost.localdomain>
 <aqCfwe5-EIiJXlIu@paquier.xyz>
 <a72c99d5b1e448b191a89e30ecaf3e8a@localhost.localdomain>
 <aqtU-qs5H3LbUum1@paquier.xyz> <aqtiKTvl519bu8-V@paquier.xyz>
 <d6ed296c81c14d03b1b5e283e913c40b@localhost.localdomain>
 <aquSa2gbfVMxDYmT@paquier.xyz>
 <0eb7233253374bce9f8ec0111a40b732@localhost.localdomain>,<arRmqBEj9n0w3qCc@paquier.xyz>
In-Reply-To: <arRmqBEj9n0w3qCc@paquier.xyz>
Accept-Language: ru-RU, en-US
Content-Language: ru-RU
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Content-Type: text/plain; charset="koi8-r"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-KLMS-Rule-ID: 1
X-KLMS-Message-Action: clean
X-KLMS-AntiSpam-Lua-Profiles: 206201 [Sep 23 2026]
X-KLMS-AntiSpam-Version: 6.1.1.27
X-KLMS-AntiSpam-Envelope-From: ju.grigorev@ftdata.ru
X-KLMS-AntiSpam-Rate: 0
X-KLMS-AntiSpam-Status: not_detected
X-KLMS-AntiSpam-Method: none
X-KLMS-AntiSpam-Auth: dkim=none
X-MS-Exchange-Organization-SCL: -1
X-KLMS-AntiSpam-Interceptor-Info: scan successful
X-KLMS-AntiPhishing: Clean, bases: 2026/09/24 03:19:00
X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30,
 bases: 2026/09/24 01:34:00 #28616465
X-KLMS-AntiVirus-Status: Clean, skipped
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ee29f27c0c9f4520b3cf2135f7dc7a2b%40localhost.localdomain>
Precedence: bulk

Hi Michael,

Thanks very much for taking the time to clean this up and commit it.  I
reviewed d9de60c -- restoring the existing refcount and generation
comments was the right call, and the shorter wording still captures the
allocation-before-insert invariant.  The final ordering and cleanup
paths look good to me.

Thanks,
  Yuriy=