Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sUnfI-005laF-Q8 for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jul 2024 13:28:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sUnfG-00Glfs-Kz for pgsql-hackers@arkaria.postgresql.org; Fri, 19 Jul 2024 13:28:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sUnfG-00Glfh-BK for pgsql-hackers@lists.postgresql.org; Fri, 19 Jul 2024 13:28:50 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sUnfD-000NKy-G1 for pgsql-hackers@postgresql.org; Fri, 19 Jul 2024 13:28:48 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2eede876fccso23676881fa.1 for ; Fri, 19 Jul 2024 06:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1721395726; x=1722000526; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mpqkC7nuB8e39vZi2jwUDhOm8V6Ax1DMX+/GbOwJe7A=; b=YbYVf+Dt2sV1oMsIC/kkh/z5mNdWaVBKyfYGGN5clI1tx5dAhR8UGi42VGb1E3j2xh /31JrVv9dglCD35IEWbD+Q0gGKnA+8d3J67TXhdv6CQ/kWBqBzYicxOcu93VrmqpHKgD gVwENdpU1ySCeUochduffRD8kDWIsUgjOzPNVwqpbB/xvbZ1moUcHLOz3VLTDUQjTY7W RntH7jVfjqiiSwMYqt4zMwB74oaIbDfCQ1/P/1IDkX9ddD0b06+c8dAcm2wUBOgpXaW2 yNKUBuBBr52xAMIZBZ44GaEXPD4KmnaOvnYRUde0hxLldjgmMRcHvTxhfTUgMGORAiJo XDqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721395726; x=1722000526; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mpqkC7nuB8e39vZi2jwUDhOm8V6Ax1DMX+/GbOwJe7A=; b=QbKLHtvs2gr7hyCdpw3VI9ZkdQy7RF4dgENQDSkOlveUHL9A4hzs992oVDMzTL+neN UR72znwJ/MtZhI43fhKBzyAHEhuJKtIpIAMv2gJ7/mMZp4QodgdLWqlculXj4j//4FqM 1p3oTH9nmbZxQefoKYqu0/9gdHga8QHrifugK2/E3O1v+TOfBnt4QH54yDpKhSgZ1yz9 Tiahc6ipCy6qjwHJPASyXDWBpyUFHePPMOy1HWB9o+5vQecntmNXikElH7sUEMa3zVK8 zN6YxjfSKFTTLguRJYACsglVSAD62DmP05RlH5JezjaFw7gKxp0AsedKLa/Q1yWePYCg 2zNg== X-Forwarded-Encrypted: i=1; AJvYcCV0Yb44D0xKkvvTZyyI2etmATBukt847GRAPHPYDyR3YgIPb64GeA8eTKn1CRFo2e6aR8JCbw7HBgrJJ9L/LIqfWjlJjAGySFz6FA4e X-Gm-Message-State: AOJu0YyrQvO1YhoBYbj5KTqveV+iQ9qUAgRlR9Yj982GzSTHb/UyyVxs xxAS8q5/w7lJQd4YF8LwDEFbk9Z3oX4ovVRg5k2JNSl+bUAwGyQSRdk5g8jkzw== X-Google-Smtp-Source: AGHT+IHci7mH7+WfJKy7MIcnQvvopfk5ZQOH58rCtZC7pwm/+sLdeAr9yiimwTxEikPu1TchqgZmQw== X-Received: by 2002:a05:651c:235:b0:2ee:8c8d:d9dd with SMTP id 38308e7fff4ca-2ef05d24f2dmr38143471fa.36.1721395725709; Fri, 19 Jul 2024 06:28:45 -0700 (PDT) Received: from [10.137.0.18] (ip-86-49-229-30.bb.vodafone.cz. [86.49.229.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30c9beccesm1182334a12.96.2024.07.19.06.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 06:28:45 -0700 (PDT) Message-ID: Date: Fri, 19 Jul 2024 15:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx To: Michael Paquier Cc: vignesh C , Anthonin Bonnefoy , Jelte Fennema-Nio , PostgreSQL Hackers References: <6cece376-07c6-4075-87b6-937156814202@enterprisedb.com> Content-Language: en-US From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 7/19/24 04:23, Michael Paquier wrote: > On Fri, Jul 19, 2024 at 12:17:44AM +0200, Tomas Vondra wrote: >> shall we do something about this patch? It seems to be in a pretty good >> shape (pretty much RFC, based on quick review), the cfbot is still >> happy, and there seems to be agreement this is a nice feature. >> >> Michael, I see you've reviewed the patch in January. Do you agree / plan >> to get it committed, or should I take a look? > > This feel off my radar a bit, thanks for the reminder :) > > I have a local branch dating back from January where this patch is > sitting, with something like 50% of the code reviewed. I'd still need > to look at the test coverage, but I did like the proposed patch a lot > based on my notes. > > I may be able to come back to that if not next week, then the week > after that. If you want to handle it yourself before that, that's > fine by me. OK, if you're already half-way through the review, I'll leave it up to you. I don't think we need to rush, and I'd have to learn about all the psql stuff first anyway. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company