Message-ID: <ee92b251-da9c-2b80-c3c5-15b51cb5736a@linaro.org>
Date: Thu, 1 Dec 2022 17:17:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.0
Subject: Re: [PATCH] Add native windows on arm64 support
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
 Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <Yw6e4dA4mmusdEsx@paquier.xyz> <Yw6oBJgXWnJsy3SE@paquier.xyz>
 <3886822.1661905738@sss.pgh.pa.us> <Yw77DNnYl1qkaW1S@paquier.xyz>
 <20476.1661967233@sss.pgh.pa.us> <Yw/9pgS35urJZu/7@paquier.xyz>
 <271611.1661998926@sss.pgh.pa.us> <YxA4F7EB3SBenvva@paquier.xyz>
 <CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
 <CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
 <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
From: Niyas Sait <niyas.sait@linaro.org>
In-Reply-To: <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ee92b251-da9c-2b80-c3c5-15b51cb5736a%40linaro.org>
Precedence: bulk


On 05/11/2022 18:31, Andres Freund wrote:
> On 2022-11-03 11:06:46 +0000, Niyas Sait wrote:
>> I've attached a new version of the patch which excludes the already merged
>> ASLR changes and add
>> small changes to handle latest changes in the build scripts.
> Note that we're planning to remove the custom windows build scripts before the
> next release, relying on the meson build instead.
> 

Thanks. I will add changes to add meson build support.

> This won't suffice with the meson build, since the relevant configure test
> also uses arm_acle.h:
> elif host_cpu == 'arm' or host_cpu == 'aarch64'
> 
>   prog = '''
> #include <arm_acle.h>
> 
> int main(void)
> {
>     unsigned int crc = 0;
>     crc = __crc32cb(crc, 0);
>     crc = __crc32ch(crc, 0);
>     crc = __crc32cw(crc, 0);
>     crc = __crc32cd(crc, 0);
> 
>     /* return computed value, to prevent the above being optimized away */
>     return crc == 0;
> }
> '''
> 
>   if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd without -march=armv8-a+crc',
>       args: test_c_args)
>     # Use ARM CRC Extension unconditionally
>     cdata.set('USE_ARMV8_CRC32C', 1)
>     have_optimized_crc = true
>   elif cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd with -march=armv8-a+crc',
>       args: test_c_args + ['-march=armv8-a+crc'])
>     # Use ARM CRC Extension, with runtime check
>     cflags_crc += '-march=armv8-a+crc'
>     cdata.set('USE_ARMV8_CRC32C', false)
>     cdata.set('USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK', 1)
>     have_optimized_crc = true
>   endif
> endif
> 
> The meson checking logic is used both for msvc and other compilers, so this
> will need to work with both.

Yes, will handle that.

-- 
Niyas