Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omzMt-0002Pe-5Y for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Oct 2022 15:28:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1omzMs-0001rW-0c for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Oct 2022 15:27:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omzMr-0001rM-MD for pgsql-hackers@lists.postgresql.org; Mon, 24 Oct 2022 15:27:57 +0000 Received: from mxout.index.de ([185.11.139.159]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omzMp-0006NS-3e for pgsql-hackers@lists.postgresql.org; Mon, 24 Oct 2022 15:27:57 +0000 Received: from remote.index.de (unknown [217.110.204.106]) by mxout.index.de (Postfix) with ESMTPS id 7806C5FFFB; Mon, 24 Oct 2022 15:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=index.de; s=dkim; t=1666625273; bh=RMZnTOSrtgzpMWouFCA1v0TziK2T7z/l5MPiCSKIZe8=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=HriUENgCw8a723QhuzvSkEgg2IZFHZhTvksM1jQOeM8BN+Ne4ocgEH1ojFxjbt1xJ qLLeULiy/TG5FucVh/WV6TYxpVKq0iApiJCJcfC9XIeD2iwEK7vHXf4jqs+nR8D38h ako0+yKDO9Puf6gQSY70GdwMk7YyfatGstyLuv0B2G3A6ccR6U3vU1jmTgnOOzMNSo AS1pLK82U315rAfAmQ/W2n6oF1udo1Xvr+9OVgSoYNf51FrFwsN6YK5tDyRaNShTbo iaHEYJwhSdy2+ErwASdCYCUnfFsadAI2p0Q4Z9V+9DAqylJQQT/EoslIzqDKQdIPqr j8BF1kI6WdTZg== Received: from acedia.index-gruppe.local (192.168.54.121) by invidia.index-gruppe.local (192.168.54.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Mon, 24 Oct 2022 17:27:51 +0200 Received: from invidia.index-gruppe.local (192.168.54.140) by acedia.index-gruppe.local (192.168.54.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Mon, 24 Oct 2022 17:27:51 +0200 Received: from invidia.index-gruppe.local ([fe80::adf7:ee83:6209:5ea2]) by invidia.index-gruppe.local ([fe80::adf7:ee83:6209:5ea2%15]) with mapi id 15.01.2507.013; Mon, 24 Oct 2022 17:27:51 +0200 From: Arne Roland To: "pgsql-hackers@lists.postgresql.org" , "reid.thompson@crunchydata.com" CC: Justin Pryzby , Ibrar Ahmed Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends. Thread-Topic: Add the ability to limit the amount of memory that can be allocated to backends. Thread-Index: AQHYvVpctKHnmm2kE0WIBHT++KETX63JI76AgAVgDoCACL8ngIAEqVeAgAQr24CAAHLOgIA9YmZ4 Date: Mon, 24 Oct 2022 15:27:51 +0000 Message-ID: References: ,<9e7969b9f6cbd2494705c7a5a21e7de0171727bb.camel@crunchydata.com> In-Reply-To: <9e7969b9f6cbd2494705c7a5a21e7de0171727bb.camel@crunchydata.com> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.54.160] Content-Type: multipart/alternative; boundary="_000_ee9486a314a341ec878fd61deadd9d3aindexde_" MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_ee9486a314a341ec878fd61deadd9d3aindexde_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Reid, could you rebase the patch again? It doesn't apply currently (http://cfbot.= cputube.org/patch_40_3867.log). Thanks! You mention, that you want to prevent the compiler from getting cute. I don't think this comments are exactly helpful in the current state. I thi= nk probably fine to just omit them. I don't understand the purpose of the result variable in exceeds_max_total_= bkend_mem. What purpose does it serve? I really like the simplicity of the suggestion here to prevent oom. I intent to play around with a lot of backends, once I get a rebased patch. Regards Arne ________________________________ From: Reid Thompson Sent: Thursday, September 15, 2022 4:58:19 PM To: Ibrar Ahmed; pgsql-hackers@lists.postgresql.org Cc: reid.thompson@crunchydata.com; Justin Pryzby Subject: Re: Add the ability to limit the amount of memory that can be allo= cated to backends. On Thu, 2022-09-15 at 12:07 +0400, Ibrar Ahmed wrote: > > The patch does not apply; please rebase the patch. > > patching file src/backend/utils/misc/guc.c > Hunk #1 FAILED at 3664. > 1 out of 1 hunk FAILED -- saving rejects to file > src/backend/utils/misc/guc.c.rej > > patching file src/backend/utils/misc/postgresql.conf.sample > rebased patches attached. Thanks, Reid --_000_ee9486a314a341ec878fd61deadd9d3aindexde_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
From: Reid Thompson <r= eid.thompson@crunchydata.com>
Sent: Thursday, September 15, 2022 4:58:19 PM
To: Ibrar Ahmed; pgsql-hackers@lists.postgresql.org
Cc: reid.thompson@crunchydata.com; Justin Pryzby
Subject: Re: Add the ability to limit the amount of memory that can = be allocated to backends.
 
On Thu, 2022-09-15 at 12:07 +0400, Ibrar Ahmed= wrote:
>
> The patch does not apply; please rebase the patch.
>
> patching file src/backend/utils/misc/guc.c
> Hunk #1 FAILED at 3664.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/backend/utils/misc/guc.c.rej 
>
> patching file src/backend/utils/misc/postgresql.conf.sample
>

rebased patches attached.

Thanks,
Reid

 --_000_ee9486a314a341ec878fd61deadd9d3aindexde_--