Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihV8W-0008EF-UX for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 08:56:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ihV8V-0006yW-Q0 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 08:56:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihV8U-0006yP-Jh for pgsql-hackers@lists.postgresql.org; Wed, 18 Dec 2019 08:56:51 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ihV8R-0006ZH-2R for pgsql-hackers@postgresql.org; Wed, 18 Dec 2019 08:56:49 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 31F2A5BF for ; Wed, 18 Dec 2019 03:56:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 18 Dec 2019 03:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=AyVylhKDuV97vkCdM/+Qmoa09MT3b kFpilrTIpXEOdw=; b=n51O6WJ/43bXc3zCuDKZc2VLjh0ItRLfUqpTgQOzfuqLz kwotDKZJric8f++7eCvjkdcXDGBZyzDwPHIaj5nJ7590TMjiuEX4TF2/C5vAbhPJ K0dVxg3yr4y6upIu7uZ1qbW4X42nKuTMSzWqlXrT+RyrF1FFCUa8WvY4eKaJwcZo WAh1PK/MaucilI77SZOPgQwgIddHt7Zv5kVu22Bq4/7/4vYNFKlrz6u/1fFB17Ai 9kZwylHRvDIvNdgYYjV/tDYga8ZRF23xnrc6s4SWf/zAznO9K+ebY432XHvrhqP4 AGeurBJWtS4gWZyK3hRD5fpPaUIVLb2m/FifVj3YQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtkedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepvffhufhokffffgggtgesmhdtre ertdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdr vghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhmqeenucffohhmrghinh epvdhnughquhgrughrrghnthdrtghomhenucfkphepleefrddvgedvrdduiedurddufedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvd hnughquhgrughrrghnthdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from april.pezone.net (p5df2a182.dip0.t-ipconnect.de [93.242.161.130]) by mail.messagingengine.com (Postfix) with ESMTPA id D65D38005A for ; Wed, 18 Dec 2019 03:56:43 -0500 (EST) To: pgsql-hackers From: Peter Eisentraut Subject: allow_system_table_mods and DROP RULE Organization: 2ndQuadrant Message-ID: Date: Wed, 18 Dec 2019 09:56:42 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D1BB55A6EDC977A8D447BD0C" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------D1BB55A6EDC977A8D447BD0C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit As a curious omission, DROP RULE does not check allow_system_table_mods. Creating and renaming a rule does, and also creating, renaming, and dropping a trigger does. The impact of this is probably nil in practice, but for consistency we should probably add that. The patch is pretty simple. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------D1BB55A6EDC977A8D447BD0C Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Disallow-dropping-rules-on-system-tables-by-default.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Disallow-dropping-rules-on-system-tables-by-default.pat"; filename*1="ch" RnJvbSAwY2ViNjIwYjE3YjE5N2IxZWZmYTk2YTQ2ZTM1YjZjMDM5NDJjYTdhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAxOCBEZWMgMjAxOSAwOTo1MjoxMCArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIERpc2FsbG93IGRyb3BwaW5nIHJ1bGVzIG9uIHN5c3RlbSB0YWJsZXMgYnkg ZGVmYXVsdAoKVGhpcyB3YXMgcHJldmlvdXNseSBub3QgY292ZXJlZCBieSBhbGxvd19zeXN0 ZW1fdGFibGVfbW9kcywgYnV0IG5vdyBpdAppcy4gIFRoZSBpbXBhY3QgaW4gcHJhY3RpY2Ug aXMgcHJvYmFibHkgbG93LCBidXQgdGhpcyBtYWtlcyBpdApjb25zaXN0ZW50IHdpdGggbW9z dCBvdGhlciBEREwgY29tbWFuZHMuCi0tLQogc3JjL2JhY2tlbmQvcmV3cml0ZS9yZXdyaXRl UmVtb3ZlLmMgICAgICAgICAgICAgICAgICAgfCAgOCArKysrKysrKwogLi4uL3Vuc2FmZV90 ZXN0cy9leHBlY3RlZC9hbHRlcl9zeXN0ZW1fdGFibGUub3V0ICAgICAgfCAxMSArKysrKysr KysrLQogLi4uL21vZHVsZXMvdW5zYWZlX3Rlc3RzL3NxbC9hbHRlcl9zeXN0ZW1fdGFibGUu c3FsICAgfCAxMCArKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmV3cml0ZS9y ZXdyaXRlUmVtb3ZlLmMgYi9zcmMvYmFja2VuZC9yZXdyaXRlL3Jld3JpdGVSZW1vdmUuYwpp bmRleCBjNWUyYWVkNThkLi5iYjk4YjY5MzZhIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9y ZXdyaXRlL3Jld3JpdGVSZW1vdmUuYworKysgYi9zcmMvYmFja2VuZC9yZXdyaXRlL3Jld3Jp dGVSZW1vdmUuYwpAQCAtMTgsNiArMTgsNyBAQAogI2luY2x1ZGUgImFjY2Vzcy9odHVwX2Rl dGFpbHMuaCIKICNpbmNsdWRlICJhY2Nlc3Mvc3lzYXR0ci5oIgogI2luY2x1ZGUgImFjY2Vz cy90YWJsZS5oIgorI2luY2x1ZGUgImNhdGFsb2cvY2F0YWxvZy5oIgogI2luY2x1ZGUgImNh dGFsb2cvZGVwZW5kZW5jeS5oIgogI2luY2x1ZGUgImNhdGFsb2cvaW5kZXhpbmcuaCIKICNp bmNsdWRlICJjYXRhbG9nL25hbWVzcGFjZS5oIgpAQCAtMjgsNiArMjksNyBAQAogI2luY2x1 ZGUgInV0aWxzL2ZtZ3JvaWRzLmgiCiAjaW5jbHVkZSAidXRpbHMvaW52YWwuaCIKICNpbmNs dWRlICJ1dGlscy9sc3lzY2FjaGUuaCIKKyNpbmNsdWRlICJ1dGlscy9yZWwuaCIKICNpbmNs dWRlICJ1dGlscy9zeXNjYWNoZS5oIgogCiAvKgpAQCAtNzIsNiArNzQsMTIgQEAgUmVtb3Zl UmV3cml0ZVJ1bGVCeUlkKE9pZCBydWxlT2lkKQogCWV2ZW50UmVsYXRpb25PaWQgPSAoKEZv cm1fcGdfcmV3cml0ZSkgR0VUU1RSVUNUKHR1cGxlKSktPmV2X2NsYXNzOwogCWV2ZW50X3Jl bGF0aW9uID0gdGFibGVfb3BlbihldmVudFJlbGF0aW9uT2lkLCBBY2Nlc3NFeGNsdXNpdmVM b2NrKTsKIAorCWlmICghYWxsb3dTeXN0ZW1UYWJsZU1vZHMgJiYgSXNTeXN0ZW1SZWxhdGlv bihldmVudF9yZWxhdGlvbikpCisJCWVyZXBvcnQoRVJST1IsCisJCQkJKGVycmNvZGUoRVJS Q09ERV9JTlNVRkZJQ0lFTlRfUFJJVklMRUdFKSwKKwkJCQkgZXJybXNnKCJwZXJtaXNzaW9u IGRlbmllZDogXCIlc1wiIGlzIGEgc3lzdGVtIGNhdGFsb2ciLAorCQkJCQkJUmVsYXRpb25H ZXRSZWxhdGlvbk5hbWUoZXZlbnRfcmVsYXRpb24pKSkpOworCiAJLyoKIAkgKiBOb3cgZGVs ZXRlIHRoZSBwZ19yZXdyaXRlIHR1cGxlIGZvciB0aGUgcnVsZQogCSAqLwpkaWZmIC0tZ2l0 IGEvc3JjL3Rlc3QvbW9kdWxlcy91bnNhZmVfdGVzdHMvZXhwZWN0ZWQvYWx0ZXJfc3lzdGVt X3RhYmxlLm91dCBiL3NyYy90ZXN0L21vZHVsZXMvdW5zYWZlX3Rlc3RzL2V4cGVjdGVkL2Fs dGVyX3N5c3RlbV90YWJsZS5vdXQKaW5kZXggY2E3ZWFiZTliYi4uZWNkMTUwNWNkYyAxMDA2 NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy91bnNhZmVfdGVzdHMvZXhwZWN0ZWQvYWx0ZXJf c3lzdGVtX3RhYmxlLm91dAorKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Vuc2FmZV90ZXN0cy9l eHBlY3RlZC9hbHRlcl9zeXN0ZW1fdGFibGUub3V0CkBAIC04MSw3ICs4MSwxNiBAQCBDUkVB VEUgUlVMRSByMSBBUyBPTiBJTlNFUlQgVE8gcGdfZGVzY3JpcHRpb24gRE8gSU5TVEVBRCBO T1RISU5HOwogRVJST1I6ICBwZXJtaXNzaW9uIGRlbmllZDogInBnX2Rlc2NyaXB0aW9uIiBp cyBhIHN5c3RlbSBjYXRhbG9nCiBBTFRFUiBSVUxFIHIxIE9OIHBnX2Rlc2NyaXB0aW9uIFJF TkFNRSBUTyByMjsKIEVSUk9SOiAgcGVybWlzc2lvbiBkZW5pZWQ6ICJwZ19kZXNjcmlwdGlv biIgaXMgYSBzeXN0ZW0gY2F0YWxvZwotLS1EUk9QIFJVTEUgcjIgT04gcGdfZGVzY3JpcHRp b247CistLSBub3cgbWFrZSBvbmUgdG8gdGVzdCBkcm9wcGluZzoKK1NFVCBhbGxvd19zeXN0 ZW1fdGFibGVfbW9kcyBUTyBvbjsKK0NSRUFURSBSVUxFIHIyIEFTIE9OIElOU0VSVCBUTyBw Z19kZXNjcmlwdGlvbiBETyBJTlNURUFEIE5PVEhJTkc7CitSRVNFVCBhbGxvd19zeXN0ZW1f dGFibGVfbW9kczsKK0RST1AgUlVMRSByMiBPTiBwZ19kZXNjcmlwdGlvbjsKK0VSUk9SOiAg cGVybWlzc2lvbiBkZW5pZWQ6ICJwZ19kZXNjcmlwdGlvbiIgaXMgYSBzeXN0ZW0gY2F0YWxv ZworLS0gY2xlYW51cDoKK1NFVCBhbGxvd19zeXN0ZW1fdGFibGVfbW9kcyBUTyBvbjsKK0RS T1AgUlVMRSByMiBPTiBwZ19kZXNjcmlwdGlvbjsKK1JFU0VUIGFsbG93X3N5c3RlbV90YWJs ZV9tb2RzOwogU0VUIGFsbG93X3N5c3RlbV90YWJsZV9tb2RzID0gb247CiAtLSBjcmVhdGUg bmV3IHRhYmxlIGluIHBnX2NhdGFsb2cKIEJFR0lOOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3Qv bW9kdWxlcy91bnNhZmVfdGVzdHMvc3FsL2FsdGVyX3N5c3RlbV90YWJsZS5zcWwgYi9zcmMv dGVzdC9tb2R1bGVzL3Vuc2FmZV90ZXN0cy9zcWwvYWx0ZXJfc3lzdGVtX3RhYmxlLnNxbApp bmRleCA0NGNiM2M3MTQ4Li41NjYzNTcwZDMxIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9tb2R1 bGVzL3Vuc2FmZV90ZXN0cy9zcWwvYWx0ZXJfc3lzdGVtX3RhYmxlLnNxbAorKysgYi9zcmMv dGVzdC9tb2R1bGVzL3Vuc2FmZV90ZXN0cy9zcWwvYWx0ZXJfc3lzdGVtX3RhYmxlLnNxbApA QCAtNzksNyArNzksMTUgQEAgQ1JFQVRFIFRSSUdHRVIgdDEgQkVGT1JFIElOU0VSVCBPTiBw Z19kZXNjcmlwdGlvbiBFWEVDVVRFIEZVTkNUSU9OIHRmMSgpOwogLS0gcnVsZXMKIENSRUFU RSBSVUxFIHIxIEFTIE9OIElOU0VSVCBUTyBwZ19kZXNjcmlwdGlvbiBETyBJTlNURUFEIE5P VEhJTkc7CiBBTFRFUiBSVUxFIHIxIE9OIHBnX2Rlc2NyaXB0aW9uIFJFTkFNRSBUTyByMjsK LS0tRFJPUCBSVUxFIHIyIE9OIHBnX2Rlc2NyaXB0aW9uOworLS0gbm93IG1ha2Ugb25lIHRv IHRlc3QgZHJvcHBpbmc6CitTRVQgYWxsb3dfc3lzdGVtX3RhYmxlX21vZHMgVE8gb247CitD UkVBVEUgUlVMRSByMiBBUyBPTiBJTlNFUlQgVE8gcGdfZGVzY3JpcHRpb24gRE8gSU5TVEVB RCBOT1RISU5HOworUkVTRVQgYWxsb3dfc3lzdGVtX3RhYmxlX21vZHM7CitEUk9QIFJVTEUg cjIgT04gcGdfZGVzY3JpcHRpb247CistLSBjbGVhbnVwOgorU0VUIGFsbG93X3N5c3RlbV90 YWJsZV9tb2RzIFRPIG9uOworRFJPUCBSVUxFIHIyIE9OIHBnX2Rlc2NyaXB0aW9uOworUkVT RVQgYWxsb3dfc3lzdGVtX3RhYmxlX21vZHM7CiAKIAogU0VUIGFsbG93X3N5c3RlbV90YWJs ZV9tb2RzID0gb247Ci0tIAoyLjI0LjEKCg== --------------D1BB55A6EDC977A8D447BD0C--